Fixes #695 #696
Merged
Fixes #695 #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…types for channel send operations
|
I've observed a non-deterministic behavior of test case |
jcp19
approved these changes
Nov 1, 2023
src/main/scala/viper/gobra/translator/encodings/channels/ChannelEncoding.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #695.
We drop the violation in the channel encoding as the type-checker is anyway more lenient and allows messages of types that are assignable (and not necessarily equal) to the channel type.
However, this change requires a small change to the channel encoding as we can no longer use the message's type when constructing the pure method calls to the channel's invariant getters (
SendGivenPerm,SendGotPerm,RecvGivenPerm, andRecvGotPerm) but have to use the channel type instead (as they are not necessarily equal anymore).