support nested dicts, maps and dicts-maps in options #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcp19
reviewed
Oct 28, 2023
There was a problem hiding this comment.
I am not sure if adding all these case distinctions is the way to go because of all the redundancy that it introduces. I think that a more maintainable way is to use Single like I did in #699 (I was gonna add this solution as a code suggestion, but it actually became harder to explain that way :D)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new two tests added in this PR were reported by Markus as not type-checking properly.
The problem was with the nested dicts where with a dict
m, the expressionm[1][1]would not typecheck sincem[1]instead of typeMathMapThas theInternalSingleMultitype.Similar problem existed with options.