Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page instance #6 #226

Closed
wants to merge 29 commits into from
Closed

Landing page instance #6 #226

wants to merge 29 commits into from

Conversation

habeeba-naaz
Copy link

Description

Please check this link for landing page

https://habeebanaaz1.wixsite.com/watermonitoringsys

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes #172

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

Swarnimashukla and others added 28 commits March 1, 2020 11:50
Line #96 Contribution  Guidelines updated with new link.
Edited the link to GirlScript Foundation
Updated link to open PRs in README.md
added badges

added badges

added badges

added badges

added badges

added badges

added badges

added badges

Added badges
Project report
* added first-timers friendly badge

* added new mentor's details

* Format 7a84c1e

* fixed italics issue in FAQs section

* Format 61f714f

* fixed font weight issue

* Format 0c2a1c3

* removed extra *

* added rgsoc snippet

* Format e645f24

* Format #134

* Format #134

* fixed issues in .md rendering

* added a snippet for rgsoc

* added info+logo for RGSOC

* added link to tweet

* added link to RGSoC issue

* added rgsoc logo

* added rgsoc logo

* added link to rgsoc issue

* Added infographic for the wiki

Co-authored-by: Vinit Shahdeo <[email protected]>
Co-authored-by: prettifier[bot] <45367598+prettifier[bot]@users.noreply.github.com>
Co-authored-by: Pragati Verma <[email protected]>
* added first-timers friendly badge

* added new mentor's details

* Format 7a84c1e

* fixed italics issue in FAQs section

* Format 61f714f

* fixed font weight issue

* Format 0c2a1c3

* removed extra *

* Format #134

* Format #134

* fixed issues in .md rendering

* Added front-end wireframe

Co-authored-by: Vinit Shahdeo <[email protected]>
Co-authored-by: prettifier[bot] <45367598+prettifier[bot]@users.noreply.github.com>
Co-authored-by: Pragati Verma <[email protected]>
* added first-timers friendly badge

* added new mentor's details

* Format 7a84c1e

* fixed italics issue in FAQs section

* Format 61f714f

* fixed font weight issue

* Format 0c2a1c3

* removed extra *

* added rgsoc snippet

* Format e645f24

* Format #134

* Format #134

* fixed issues in .md rendering

* added a snippet for rgsoc

* added info+logo for RGSOC

* added link to tweet

* added link to RGSoC issue

* added rgsoc logo

* added rgsoc logo

* added link to rgsoc issue

* added links to hall of fame badge

* Update README.md

Added Gitpod Button

* Update LICENSE

Updated Copyright Year to 2020

* Added .gitpod.yml file

Added Gitpod Button Tasks file

Co-authored-by: Vinit Shahdeo <[email protected]>
Co-authored-by: prettifier[bot] <45367598+prettifier[bot]@users.noreply.github.com>
Co-authored-by: Vinit Shahdeo <[email protected]>
@amaaniqbal
Copy link

Please pull the upstream changes before pushing anything. Also, you are not required to develop the website on your own for this task. Although it might help us later since you have done it. You can create a separate issue for this on our repo and assign it to yourself. Then you can submit your work as a submission.
For this task, you can take the screenshot of the webpage and add it inside the screenshots/ directory as others have done. Good Luck!

@habeeba-naaz
Copy link
Author

Okay sure...thank you for advice

@PragatiVerma18
Copy link
Contributor

@habeeba-naaz please resolve merge conflicts before you submit for review again and please see that your changes are not to be pushed to the master branch but to the feature/documentation branch.

@habeeba-naaz
Copy link
Author

habeeba-naaz commented Apr 3, 2020

can i close this pull request and make another PR...?

@amaaniqbal
Copy link

You can update this PR too if you wish. If you find that difficult, you may close this and open a new one.

@habeeba-naaz
Copy link
Author

I opened a new one but that linked to another issue

@habeeba-naaz
Copy link
Author

habeeba-naaz commented Apr 3, 2020

I pushed to feature/documentation but it got linked to other issue..Which Is not related to it actually I didn’t created PR yet .what should I do?

@amaaniqbal
Copy link

You have to create a PR for the design task to the feature/frontend branch and not to the feature/documentation branch. If you find it difficult to work with this PR, you can close this PR, update your local copy of the repo by pulling the feature/frontend branch from the upstream using a command something like git pull upstream feature/frontend, and then add your designs inside the screenshots/Instance #{number} directory. After that, you can create a PR. Good Luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create landing page design [easy/medium] - Instance #6