Virtual branch 2

[vicb]

Summary by Sourcery

Add support for a 'None' scoring rule to process tracks without scoring, refactor path handling for improved type safety, and update tests to cover the new rule. Enhance the optimizer to return unoptimized solutions for undefined scoring rules.

New Features:

• Introduce a new scoring rule 'None' which allows for tracks to be processed without applying any scoring rules.

Enhancements:

• Refactor the optimizer to handle undefined scoring rules by returning an unoptimized solution instead of throwing an error.
• Update the path handling in the optimizer to use a consistent LatLon type, improving type safety and code clarity.

Documentation:

• Update the CHANGELOG.md to reflect recent changes and additions.

Tests:

• Modify tests to include the new 'None' scoring rule, ensuring that it is handled correctly across different scenarios.

[coderabbitai]

Warning

Rate limit exceeded

@vicb has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 9 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 125f9ef and 17edbe9.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

Early access features: enabled

We are currently testing the following features in early access:

• OpenAI o1 for code reviews: OpenAI's new o1 model is being tested for generating code suggestions in code reviews.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request implements several changes to the optimizer library and related components, focusing on improving the scoring system, adding a new 'None' scoring option, and refactoring some code for better type safety and performance. The changes also include minor updates to the frontend application.

File-Level Changes

Change	Details	Files
Added 'None' scoring option	Introduced a new 'None' scoring rule Updated scoring rules map to include 'None' option Modified frontend components to handle 'None' scoring option Updated league codes and details to include 'None' option	libs/optimizer/src/lib/scoring-rules.ts libs/optimizer/src/lib/optimizer.ts libs/optimizer/src/lib/api.ts apps/fxc-front/src/app/components/2d/planner-element.ts apps/fxc-front/src/app/logic/score/league/leagues.ts
Refactored optimizer for better type safety and error handling	Changed path type from array of objects to LatLon[] Implemented toUnoptimizedSolution function for handling unknown scoring rules Updated getOptimizer function to use toUnoptimizedSolution for undefined scoring rules Added distanceEarthFCC function for distance calculations	libs/optimizer/src/lib/optimizer.ts
Updated frontend components to work with new optimizer changes	Modified PathElement to handle new LatLon[] path format Updated PlannerElement to conditionally render score track option based on league Added league state to PlannerElement	apps/fxc-front/src/app/components/2d/path-element.ts apps/fxc-front/src/app/components/2d/planner-element.ts
Minor frontend updates and code cleanup	Reformatted HTML structure in index.html Updated variable names in scoring-rules.ts for clarity Added type declaration for 'igc-xc-score/src/foundation' module	apps/fxc-front/index.html libs/optimizer/src/lib/scoring-rules.ts libs/optimizer/src/modules.d.ts CHANGELOG.md

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @vicb - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[cloudflare-workers-and-pages]

Deploying flyxc with    Cloudflare Pages

Latest commit:	17edbe9
Status:	✅  Deploy successful!
Preview URL:	https://5e3a0dce.flyxc.pages.dev
Branch Preview URL:	https://virtual-branch-2.flyxc.pages.dev

View logs