-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: saving state of features upon reload #27
Open
shameerrehman
wants to merge
12
commits into
main
Choose a base branch
from
widget-state-save
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1c786f8
adding state saving for contrast, screen-reader, saturate, text-size,…
shameerrehman ed8f5f5
code refactor to add superclass for components
shameerrehman 1a5f97e
Merge branch 'main' into widget-state-save
shameerrehman 39363b3
adding safe states to new components
shameerrehman 647dd5d
updating test case
shameerrehman 3440ade
applying code review fix
shameerrehman 388dd10
refactor: fixing code review comment
shameerrehman f5ac2e2
running prettier
shameerrehman f4dc7a9
Merge branch 'main' into widget-state-save
shameerrehman 6b4d336
updating pretier
shameerrehman 7a78546
adding documentation for state saving
shameerrehman 2c2ba55
running prettier
shameerrehman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
projects/astral-accessibility/src/lib/controls/accessibility.component.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import { Component } from "@angular/core"; | ||
|
||
@Component({ | ||
standalone: true, | ||
template: ``, | ||
imports: [], | ||
}) | ||
export abstract class AccessibilityComponent { | ||
constructor() {} | ||
|
||
changeState(currentState: number, state: string, numOfStates: number) { | ||
currentState += 1; | ||
currentState = currentState % numOfStates; | ||
this.saveState(state, JSON.stringify(currentState)); | ||
return currentState; | ||
} | ||
|
||
saveState(key: string, value: string) { | ||
localStorage.setItem(key, value); | ||
} | ||
|
||
getState(key: string) { | ||
const textSizeState = localStorage.getItem(key); | ||
return Number(textSizeState); | ||
} | ||
|
||
setLogic(state: string) { | ||
const currentState = this.getState(state); | ||
if (currentState == null) { | ||
return 0; | ||
} else { | ||
this._runStateLogic(); | ||
return currentState; | ||
} | ||
} | ||
|
||
protected _runStateLogic() { | ||
//to be overridden | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like first and last argument can be defined only in
accessibility.component.ts
, and we can make the second argument be defined as a class variable and have the parent read it as well. Hope that makes sense.Read more on Template Method Design Pattern: https://refactoring.guru/design-patterns/template-method