Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(turbopack): Remove last known (non-test) usages of unresolved vcs in turbo_tasks::value (!!!) #74713

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

bgw
Copy link
Member

@bgw bgw commented Jan 9, 2025

Closes PACK-3718

Copy link
Member Author

bgw commented Jan 9, 2025

@bgw bgw changed the title refactor(turbopack): Remove last known (non-test) usages of unresolved vcs in turbo_tasks::value! refactor(turbopack): Remove last known (non-test) usages of unresolved vcs in turbo_tasks::value (!!!) Jan 9, 2025
@bgw bgw requested review from kdy1, mischnic and sokra January 9, 2025 21:22
@bgw bgw marked this pull request as ready for review January 9, 2025 21:22
@ijjk
Copy link
Member

ijjk commented Jan 9, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js bgw/turbopack-last-local Change
buildDuration 20.4s 18.2s N/A
buildDurationCached 17.4s 14.6s N/A
nodeModulesSize 417 MB 417 MB
nextStartRea..uration (ms) 505ms 496ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/turbopack-last-local Change
5306-HASH.js gzip 53.3 kB 53.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.2 kB 34.2 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/turbopack-last-local Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js bgw/turbopack-last-local Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/turbopack-last-local Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/turbopack-last-local Change
index.html gzip 524 B 524 B
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/turbopack-last-local Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 207 kB 207 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js bgw/turbopack-last-local Change
middleware-b..fest.js gzip 670 B 671 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js bgw/turbopack-last-local Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 369 kB 369 kB
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 138 kB 138 kB
app-page.run...dev.js gzip 357 kB 357 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.46 MB 2.46 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/turbopack-last-local Change
0.pack gzip 2.09 MB 2.1 MB ⚠️ +612 B
index.pack gzip 74.7 kB 75.2 kB ⚠️ +428 B
Overall change 2.17 MB 2.17 MB ⚠️ +1.04 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: df1d0ab

@bgw bgw force-pushed the bgw/packages-globs branch from 23fec2f to ac9f99c Compare January 10, 2025 21:19
@bgw bgw force-pushed the bgw/turbopack-last-local branch from 49f8c74 to 0f2804e Compare January 10, 2025 21:19
@bgw bgw force-pushed the bgw/packages-globs branch from ac9f99c to 1d06c80 Compare January 10, 2025 22:45
@bgw bgw force-pushed the bgw/turbopack-last-local branch from 0f2804e to ac157ba Compare January 10, 2025 22:46
@bgw bgw force-pushed the bgw/packages-globs branch from 1d06c80 to afe49c9 Compare January 10, 2025 23:10
@bgw bgw force-pushed the bgw/turbopack-last-local branch from ac157ba to a071c44 Compare January 10, 2025 23:10
@bgw bgw force-pushed the bgw/packages-globs branch from afe49c9 to aec4700 Compare January 10, 2025 23:45
@bgw bgw force-pushed the bgw/turbopack-last-local branch from a071c44 to eba95ea Compare January 10, 2025 23:45
@bgw bgw force-pushed the bgw/packages-globs branch from aec4700 to f04e03e Compare January 11, 2025 00:30
@bgw bgw force-pushed the bgw/turbopack-last-local branch from eba95ea to 17b494e Compare January 11, 2025 00:31
@bgw bgw force-pushed the bgw/packages-globs branch from f04e03e to 535dcd4 Compare January 11, 2025 01:38
@bgw bgw force-pushed the bgw/turbopack-last-local branch from 17b494e to 7186c13 Compare January 11, 2025 01:38
@bgw bgw force-pushed the bgw/packages-globs branch from 535dcd4 to 706b473 Compare January 11, 2025 02:08
@bgw bgw force-pushed the bgw/turbopack-last-local branch from 7186c13 to 055f3a6 Compare January 11, 2025 02:09
@bgw bgw force-pushed the bgw/packages-globs branch from 706b473 to c02e5fa Compare January 13, 2025 16:30
@bgw bgw force-pushed the bgw/turbopack-last-local branch from 055f3a6 to c0a05b9 Compare January 13, 2025 16:35
@bgw bgw force-pushed the bgw/packages-globs branch from c02e5fa to ae4afff Compare January 13, 2025 18:05
@bgw bgw force-pushed the bgw/turbopack-last-local branch from c0a05b9 to b4da462 Compare January 13, 2025 18:05
@bgw bgw force-pushed the bgw/packages-globs branch from ae4afff to c9e6c17 Compare January 13, 2025 19:10
@bgw bgw force-pushed the bgw/turbopack-last-local branch from b4da462 to f611e3d Compare January 13, 2025 19:11
@bgw bgw force-pushed the bgw/packages-globs branch 2 times, most recently from 4c3aebb to 5080011 Compare January 13, 2025 20:29
@bgw bgw force-pushed the bgw/turbopack-last-local branch from f611e3d to 4c2249b Compare January 13, 2025 20:29
@bgw bgw changed the base branch from bgw/packages-globs to graphite-base/74713 January 13, 2025 22:06
@bgw bgw force-pushed the bgw/turbopack-last-local branch from 4c2249b to 5ed2f16 Compare January 13, 2025 22:07
@bgw bgw force-pushed the graphite-base/74713 branch from 5080011 to d710482 Compare January 13, 2025 22:07
@bgw bgw changed the base branch from graphite-base/74713 to canary January 13, 2025 22:07
@bgw bgw force-pushed the bgw/turbopack-last-local branch from 5ed2f16 to df1d0ab Compare January 13, 2025 22:08
@ijjk
Copy link
Member

ijjk commented Jan 13, 2025

Tests Passed

@bgw bgw merged commit 99c4dc3 into canary Jan 13, 2025
126 of 131 checks passed
Copy link
Member Author

bgw commented Jan 13, 2025

Merge activity

  • Jan 13, 5:48 PM EST: A user merged this pull request with Graphite.

@bgw bgw deleted the bgw/turbopack-last-local branch January 13, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants