-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(turbopack): Remove last known (non-test) usages of unresolved vcs in turbo_tasks::value (!!!) #74713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
created-by: Turbopack team
PRs by the Turbopack team.
Turbopack
Related to Turbopack with Next.js.
labels
Jan 9, 2025
This was referenced Jan 9, 2025
refactor(turbopack/next-api): Implement NonLocalValue for TracedDiGraph and SingleModuleGraph
#74506
Merged
Merged
Merged
Merged
This was referenced Jan 9, 2025
Merged
bgw
changed the title
refactor(turbopack): Remove last known (non-test) usages of unresolved vcs in turbo_tasks::value!
refactor(turbopack): Remove last known (non-test) usages of unresolved vcs in turbo_tasks::value (!!!)
Jan 9, 2025
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js bgw/turbopack-last-local | Change | |
---|---|---|---|
buildDuration | 20.4s | 18.2s | N/A |
buildDurationCached | 17.4s | 14.6s | N/A |
nodeModulesSize | 417 MB | 417 MB | ✓ |
nextStartRea..uration (ms) | 505ms | 496ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js bgw/turbopack-last-local | Change | |
---|---|---|---|
5306-HASH.js gzip | 53.3 kB | 53.3 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.44 kB | 5.44 kB | N/A |
bccd1874-HASH.js gzip | 52.9 kB | 52.9 kB | N/A |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 241 B | 242 B | N/A |
main-HASH.js gzip | 34.2 kB | 34.2 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js bgw/turbopack-last-local | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js bgw/turbopack-last-local | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.57 kB | 4.57 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.34 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js bgw/turbopack-last-local | Change | |
---|---|---|---|
_buildManifest.js gzip | 749 B | 747 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js bgw/turbopack-last-local | Change | |
---|---|---|---|
index.html gzip | 524 B | 524 B | ✓ |
link.html gzip | 539 B | 538 B | N/A |
withRouter.html gzip | 520 B | 520 B | ✓ |
Overall change | 1.04 kB | 1.04 kB | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js bgw/turbopack-last-local | Change | |
---|---|---|---|
edge-ssr.js gzip | 129 kB | 129 kB | N/A |
page.js gzip | 207 kB | 207 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js bgw/turbopack-last-local | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 670 B | 671 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.2 kB | 31.2 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js bgw/turbopack-last-local | Change | |
---|---|---|---|
274-experime...dev.js gzip | 322 B | 322 B | ✓ |
274.runtime.dev.js gzip | 314 B | 314 B | ✓ |
app-page-exp...dev.js gzip | 369 kB | 369 kB | ✓ |
app-page-exp..prod.js gzip | 130 kB | 130 kB | ✓ |
app-page-tur..prod.js gzip | 142 kB | 142 kB | ✓ |
app-page-tur..prod.js gzip | 138 kB | 138 kB | ✓ |
app-page.run...dev.js gzip | 357 kB | 357 kB | ✓ |
app-page.run..prod.js gzip | 126 kB | 126 kB | ✓ |
app-route-ex...dev.js gzip | 37.6 kB | 37.6 kB | ✓ |
app-route-ex..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
app-route.ru...dev.js gzip | 39.2 kB | 39.2 kB | ✓ |
app-route.ru..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
pages-api.ru...dev.js gzip | 11.6 kB | 11.6 kB | ✓ |
pages-api.ru..prod.js gzip | 9.68 kB | 9.68 kB | ✓ |
pages-turbo...prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
pages.runtim...dev.js gzip | 27.5 kB | 27.5 kB | ✓ |
pages.runtim..prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
server.runti..prod.js gzip | 916 kB | 916 kB | ✓ |
Overall change | 2.46 MB | 2.46 MB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js bgw/turbopack-last-local | Change | |
---|---|---|---|
0.pack gzip | 2.09 MB | 2.1 MB | |
index.pack gzip | 74.7 kB | 75.2 kB | |
Overall change | 2.17 MB | 2.17 MB |
Diff details
Diff for main-HASH.js
Diff too large to display
kdy1
approved these changes
Jan 10, 2025
sokra
approved these changes
Jan 10, 2025
bgw
force-pushed
the
bgw/packages-globs
branch
from
January 10, 2025 21:19
23fec2f
to
ac9f99c
Compare
bgw
force-pushed
the
bgw/turbopack-last-local
branch
from
January 10, 2025 21:19
49f8c74
to
0f2804e
Compare
bgw
force-pushed
the
bgw/packages-globs
branch
from
January 10, 2025 22:45
ac9f99c
to
1d06c80
Compare
bgw
force-pushed
the
bgw/turbopack-last-local
branch
from
January 10, 2025 22:46
0f2804e
to
ac157ba
Compare
bgw
force-pushed
the
bgw/packages-globs
branch
from
January 10, 2025 23:10
1d06c80
to
afe49c9
Compare
bgw
force-pushed
the
bgw/turbopack-last-local
branch
from
January 10, 2025 23:10
ac157ba
to
a071c44
Compare
bgw
force-pushed
the
bgw/packages-globs
branch
from
January 10, 2025 23:45
afe49c9
to
aec4700
Compare
bgw
force-pushed
the
bgw/turbopack-last-local
branch
from
January 10, 2025 23:45
a071c44
to
eba95ea
Compare
bgw
force-pushed
the
bgw/packages-globs
branch
from
January 11, 2025 00:30
aec4700
to
f04e03e
Compare
bgw
force-pushed
the
bgw/turbopack-last-local
branch
from
January 11, 2025 00:31
eba95ea
to
17b494e
Compare
bgw
force-pushed
the
bgw/packages-globs
branch
from
January 11, 2025 01:38
f04e03e
to
535dcd4
Compare
bgw
force-pushed
the
bgw/turbopack-last-local
branch
from
January 11, 2025 01:38
17b494e
to
7186c13
Compare
bgw
force-pushed
the
bgw/packages-globs
branch
from
January 11, 2025 02:08
535dcd4
to
706b473
Compare
bgw
force-pushed
the
bgw/turbopack-last-local
branch
from
January 11, 2025 02:09
7186c13
to
055f3a6
Compare
bgw
force-pushed
the
bgw/packages-globs
branch
from
January 13, 2025 16:30
706b473
to
c02e5fa
Compare
bgw
force-pushed
the
bgw/turbopack-last-local
branch
from
January 13, 2025 16:35
055f3a6
to
c0a05b9
Compare
bgw
force-pushed
the
bgw/packages-globs
branch
from
January 13, 2025 18:05
c02e5fa
to
ae4afff
Compare
bgw
force-pushed
the
bgw/turbopack-last-local
branch
from
January 13, 2025 18:05
c0a05b9
to
b4da462
Compare
bgw
force-pushed
the
bgw/packages-globs
branch
from
January 13, 2025 19:10
ae4afff
to
c9e6c17
Compare
bgw
force-pushed
the
bgw/turbopack-last-local
branch
from
January 13, 2025 19:11
b4da462
to
f611e3d
Compare
bgw
force-pushed
the
bgw/packages-globs
branch
2 times, most recently
from
January 13, 2025 20:29
4c3aebb
to
5080011
Compare
bgw
force-pushed
the
bgw/turbopack-last-local
branch
from
January 13, 2025 20:29
f611e3d
to
4c2249b
Compare
bgw
force-pushed
the
bgw/turbopack-last-local
branch
from
January 13, 2025 22:07
4c2249b
to
5ed2f16
Compare
bgw
force-pushed
the
graphite-base/74713
branch
from
January 13, 2025 22:07
5080011
to
d710482
Compare
…d vcs in turbo_tasks::value!
bgw
force-pushed
the
bgw/turbopack-last-local
branch
from
January 13, 2025 22:08
5ed2f16
to
df1d0ab
Compare
Tests Passed |
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PACK-3718