Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevOverlay] Add CodeFrame #74682

Draft
wants to merge 4 commits into
base: 01-09-_devoverlay_add_call_stack
Choose a base branch
from

Conversation

devjiwonchoi
Copy link
Member

No description provided.

@ijjk
Copy link
Member

ijjk commented Jan 9, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js 01-09-_devoverlay_add_codeframe Change
buildDuration 18.9s 17s N/A
buildDurationCached 16.1s 13.6s N/A
nodeModulesSize 418 MB 418 MB N/A
nextStartRea..uration (ms) 485ms 469ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-09-_devoverlay_add_codeframe Change
5306-HASH.js gzip 53.3 kB 52.8 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-09-_devoverlay_add_codeframe Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-09-_devoverlay_add_codeframe Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-09-_devoverlay_add_codeframe Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-09-_devoverlay_add_codeframe Change
index.html gzip 523 B 523 B
link.html gzip 538 B 537 B N/A
withRouter.html gzip 519 B 520 B N/A
Overall change 523 B 523 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-09-_devoverlay_add_codeframe Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 207 kB 206 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-09-_devoverlay_add_codeframe Change
middleware-b..fest.js gzip 668 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 01-09-_devoverlay_add_codeframe Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 368 kB 366 kB N/A
app-page-exp..prod.js gzip 129 kB 129 kB N/A
app-page-tur..prod.js gzip 142 kB 142 kB N/A
app-page-tur..prod.js gzip 138 kB 138 kB N/A
app-page.run...dev.js gzip 355 kB 355 kB N/A
app-page.run..prod.js gzip 126 kB 125 kB N/A
app-route-ex...dev.js gzip 37.6 kB 37.5 kB N/A
app-route-ex..prod.js gzip 25.6 kB 25.6 kB N/A
app-route-tu..prod.js gzip 25.6 kB 25.6 kB N/A
app-route-tu..prod.js gzip 25.4 kB 25.4 kB N/A
app-route.ru...dev.js gzip 39.2 kB 39.2 kB N/A
app-route.ru..prod.js gzip 25.4 kB 25.4 kB N/A
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB N/A
pages.runtim...dev.js gzip 27.5 kB 27.5 kB N/A
pages.runtim..prod.js gzip 21.7 kB 21.7 kB N/A
server.runti..prod.js gzip 916 kB 916 kB N/A
Overall change 31.6 kB 31.6 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-09-_devoverlay_add_codeframe Change
0.pack gzip 2.09 MB 2.09 MB ⚠️ +235 B
index.pack gzip 75.1 kB 75.4 kB ⚠️ +358 B
Overall change 2.17 MB 2.17 MB ⚠️ +593 B
Diff details
Diff for 5306-HASH.js

Diff too large to display

Diff for bccd1874-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for pages-turbo...time.prod.js

Diff too large to display

Diff for pages.runtime.dev.js

Diff too large to display

Diff for pages.runtime.prod.js

Diff too large to display

Diff for server.runtime.prod.js
failed to diff
Commit: 889970d

@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_call_stack branch from 95a41b2 to baab20c Compare January 9, 2025 09:41
@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_codeframe branch from 11b99f0 to a8c2b5d Compare January 9, 2025 09:41
@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_call_stack branch from baab20c to 5e65707 Compare January 9, 2025 13:29
@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_codeframe branch from a8c2b5d to c9b03b0 Compare January 9, 2025 13:29
@ijjk
Copy link
Member

ijjk commented Jan 9, 2025

Tests Passed

@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_call_stack branch from 5e65707 to 80f0b0f Compare January 9, 2025 15:46
@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_codeframe branch from 91e9373 to b0031df Compare January 9, 2025 15:46
@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_call_stack branch from 80f0b0f to 6f128a6 Compare January 10, 2025 06:56
@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_codeframe branch from 889970d to 76d4b38 Compare January 10, 2025 06:56
@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_call_stack branch from 6f128a6 to 55a52d7 Compare January 10, 2025 08:13
@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_codeframe branch from 76d4b38 to 4f46bfb Compare January 10, 2025 08:14
@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_call_stack branch from 55a52d7 to 2bd7bf5 Compare January 10, 2025 08:38
@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_codeframe branch from 4f46bfb to 6b23a14 Compare January 10, 2025 08:38
@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_call_stack branch from 2bd7bf5 to 1742596 Compare January 10, 2025 08:44
@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_codeframe branch from 688ad03 to 9fb7bf1 Compare January 10, 2025 08:44
@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_call_stack branch from 1742596 to c4ff1a3 Compare January 10, 2025 08:53
@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_codeframe branch from 9fb7bf1 to e345bd3 Compare January 10, 2025 08:53
@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_call_stack branch from c4ff1a3 to 38f19e5 Compare January 10, 2025 09:04
@devjiwonchoi devjiwonchoi force-pushed the 01-09-_devoverlay_add_codeframe branch from e345bd3 to c5efab7 Compare January 10, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants