-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): major publish.yml refactoring #22151
Draft
pront
wants to merge
6
commits into
master
Choose a base branch
from
pront/publish-yml-refactoring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pront
added
the
no-changelog
Changes in this PR do not need user-facing explanations in the release changelog
label
Jan 9, 2025
add missing needs section
pront
force-pushed
the
pront/publish-yml-refactoring
branch
from
January 9, 2025 19:43
e36814a
to
9bdcc65
Compare
pront
commented
Jan 9, 2025
name: Download Artifacts | ||
runs-on: ubuntu-20.04 | ||
needs: | ||
- build-x86_64-unknown-linux-gnu-packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these builds are also repetitive and can be refactored in another PR
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.44s Total Time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no-changelog
Changes in this PR do not need user-facing explanations in the release changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Significantly reduces usage of
actions/download-artifact
.Change Type
Is this a breaking change?
How did you test this PR?
https://github.com/vectordotdev/vector/actions/runs/12698476258
Does this PR include user facing changes?
Checklist
Cargo.lock
), pleaserun
dd-rust-license-tool write
to regenerate the license inventory and commit the changes (if any). More details here.References
Ref: #22140