Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): major publish.yml refactoring #22151

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pront
Copy link
Member

@pront pront commented Jan 9, 2025

Summary

Significantly reduces usage of actions/download-artifact.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

https://github.com/vectordotdev/vector/actions/runs/12698476258

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

Ref: #22140

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 9, 2025
pront added 2 commits January 9, 2025 14:30
add missing needs section
@pront pront force-pushed the pront/publish-yml-refactoring branch from e36814a to 9bdcc65 Compare January 9, 2025 19:43
name: Download Artifacts
runs-on: ubuntu-20.04
needs:
- build-x86_64-unknown-linux-gnu-packages
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these builds are also repetitive and can be refactored in another PR

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Jan 9, 2025

Datadog Report

Branch report: pront/publish-yml-refactoring
Commit report: 019413f
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.44s Total Time

@pront pront marked this pull request as ready for review January 9, 2025 21:07
@pront pront requested a review from a team as a code owner January 9, 2025 21:07
@pront pront marked this pull request as draft January 9, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant