feat(#16369): add a udm events endpoint to the emulator for testing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @pront, do you have permission to merge this? |
Yes, taking a look |
|
Hey @ChocPanda, is this is used for Vector integration tests in our CI? |
Yes it is, atleast I hope so, I think this is the docker image used here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing purposes I haven't bothered to validate that the incoming log events fully fulfil the UDM event format as I don't think Vector should be responsible for validating this. I've added some basic validation for some metadata fields that would be expected otherwise it will be the responsibility of the user to use transformers etc to ensure the events sent to Chronicle are in the appropriate UDM format with the required fields
Required for vectordotdev/vector#22155