-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This PR addresses issues found in https://github.com/valory-xyz/open-autonomy/pull/1701 #518
Changes from all commits
5e12b4d
39acbf4
b7bea86
6ab74a5
ec5d419
16c6cf0
7688d89
4270ca9
6fedfca
772df27
0a9f855
2c94de2
7427cd5
040cda5
49181bc
b77ab2d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
# -*- coding: utf-8 -*- | ||
# ------------------------------------------------------------------------------ | ||
# | ||
# Copyright 2021-2022 Valory AG | ||
# Copyright 2021-2023 Valory AG | ||
# Copyright 2018-2019 Fetch.AI Limited | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
|
@@ -37,7 +37,7 @@ | |
from aea.cli.utils.context import Context | ||
from aea.cli.utils.decorators import check_aea_project | ||
from aea.cli.utils.package_utils import get_package_path | ||
from aea.components.base import load_aea_package | ||
from aea.components.base import load_aea_package, perform_load_aea_package | ||
from aea.configurations.base import ComponentConfiguration | ||
from aea.configurations.constants import ( | ||
AEA_TEST_DIRNAME, | ||
|
@@ -437,6 +437,13 @@ def load_package( | |
) | ||
configuration.directory = package_dir | ||
load_aea_packages_recursively(configuration, package_path_finder, root_packages) | ||
else: | ||
perform_load_aea_package( | ||
dir_=package_dir, | ||
author=package_dir.parent.parent.name, | ||
package_type_plural=PackageType(package_type).to_plural(), | ||
package_name=package_dir.name, | ||
) | ||
Comment on lines
+440
to
+446
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This addresses https://github.com/valory-xyz/open-autonomy/actions/runs/3819359169/jobs/6496927078#step:7:9939 failure. We load agent packages in same manner as we load the component packages before running the tests There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where is the test for this branch? Why was it not required before? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We did not load the agent package before because there was no code part of the agent component similar to other components so we could run the test without loading the agent package. When I was recreating this issue locally I found out that this issue only occurs in one specific condition that is if you run the tests in a tox env and all packages available. When I ran tests for agents only by modifying the test command they ran without any issue and when I ran the same command we run in the tox env normally they ran without any issues as well. So my assumption is since we're loading the components other than the agents the references in the Now this did not happen before, this started happening after the release of |
||
|
||
test_package_dir = package_dir / AEA_TEST_DIRNAME | ||
enforce( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post release bump