Skip to content

Commit

Permalink
ci: reorder auth step in workflow (#184)
Browse files Browse the repository at this point in the history
This has to be after the checkout action, otherwise the workspace folder
where the GCP credentials are stored won't exist
  • Loading branch information
satish-ravi authored Jul 24, 2024
1 parent 641da41 commit b0a5504
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/workflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ jobs:
- test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: 'package.json'
check-latest: true
# Repo needs to be given access to the MAINNET_SERVICE_ACCOUNT_KEY secret to access the slack webhook
# https://github.com/organizations/valora-inc/settings/secrets/actions/MAINNET_SERVICE_ACCOUNT_KEY
- uses: google-github-actions/auth@v2
Expand All @@ -84,11 +89,6 @@ jobs:
# This can point to any slack webhook URL stored in GC Secret Manager
secrets: |-
SLACK_WEBHOOK_URL:projects/1027349420744/secrets/SLACK_ONCALL_WEBHOOK_URL
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: 'package.json'
check-latest: true
- run: yarn
- run: yarn deploy
- uses: ravsamhq/notify-slack-action@v2
Expand Down

0 comments on commit b0a5504

Please sign in to comment.