Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage for COMMANDLOG HELP #1617

Merged

Conversation

zuiderkwast
Copy link
Contributor

Fixes reply-schema-validator test job which needs coverage for all commands.

Failing job: https://github.com/valkey-io/valkey/actions/runs/12969591890/job/36173810824

Signed-off-by: Viktor Söderqvist <[email protected]>
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.98%. Comparing base (9071a5c) to head (8363aeb).
Report is 1 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1617      +/-   ##
============================================
+ Coverage     70.85%   70.98%   +0.12%     
============================================
  Files           121      121              
  Lines         65169    65169              
============================================
+ Hits          46176    46260      +84     
+ Misses        18993    18909      -84     

see 12 files with indirect coverage changes

@zuiderkwast zuiderkwast merged commit 6657757 into valkey-io:unstable Jan 27, 2025
49 checks passed
@zuiderkwast zuiderkwast deleted the commandlog-help-coverage branch January 27, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants