Skip to content

Commit

Permalink
Update release notes with final security information
Browse files Browse the repository at this point in the history
Signed-off-by: Madelyn Olson <[email protected]>
  • Loading branch information
madolson committed Jan 7, 2025
1 parent cff4d56 commit d6a2f56
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
7 changes: 7 additions & 0 deletions 00-RELEASENOTES
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,19 @@ Bug fixes
mode. (#1155)
* Send the correct error message when `FUNCTION KIlL` is used to kill an
ongoing script. (#1171)
* Fix a potential memory corruption when databases are emptied, such as
through `FLUSHDB`, when during active defrag is running. (#1512)

Behavior changes
================
* Revert an unintended breaking change when sending an unsubuscribe command
when a client is not subscribed to any channels. (#1265)

Security fixes
==============
* (CVE-2024-46981) Lua script commands may lead to remote code execution. (#1513)
* (CVE-2024-51741) Denial-of-service due to malformed ACL selectors. (#1514)

================================================================================
Valkey 8.0.1 - Released Tue 1 Oct 2024
================================================================================
Expand Down
2 changes: 1 addition & 1 deletion src/eval.c
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ void scriptingInit(int setup) {
void freeLuaScriptsSync(dict *lua_scripts, list *lua_scripts_lru_list, lua_State *lua) {
dictRelease(lua_scripts);
listRelease(lua_scripts_lru_list);
lua_gc(lctx.lua, LUA_GCCOLLECT, 0);
lua_gc(lua, LUA_GCCOLLECT, 0);
lua_close(lua);

#if !defined(USE_LIBC)
Expand Down
2 changes: 1 addition & 1 deletion src/sort.c
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ void sortCommandGeneric(client *c, int readonly) {
/* If GET is specified with a real pattern, we can't accept it in cluster mode,
* unless we can make sure the keys formed by the pattern are in the same slot
* as the key to sort. */
if (server.cluster_enabled &&
if (server.cluster_enabled && !isReturnSubstPattern(c->argv[j + 1]->ptr) &&
!isReturnSubstPattern(c->argv[j + 1]->ptr) &&
patternHashSlot(c->argv[j + 1]->ptr, sdslen(c->argv[j + 1]->ptr)) != getKeySlot(c->argv[1]->ptr)) {
addReplyError(c, "GET option of SORT denied in Cluster mode when "
Expand Down

0 comments on commit d6a2f56

Please sign in to comment.