Go: ZRANGE #2925
Merged
Go: ZRANGE #2925
+538
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
8 tasks
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
| @@ -1476,6 +1476,36 @@ func (client *baseClient) BZPopMin(keys []string, timeoutSecs float64) (Result[K | |||
| return handleKeyWithMemberAndScoreResponse(result) | |||
| } | |||
|
|
|||
| // TODO rework once we get other handlers - return `[]string` | |||
| func (client *baseClient) ZRange(key string, rangeQuery options.ZRangeQuery) ([]Result[string], error) { | |||
There was a problem hiding this comment.
In most places, we have passed options as a pointer. Is there any difference?
There was a problem hiding this comment.
rangeQuery is a mandatory argument for that command
jbrinkman
approved these changes
Jan 10, 2025
| // // `result` contains members with scores within the range of negative infinity to 3, in descending order | ||
| // | ||
| // [valkey.io]: https://valkey.io/commands/zrange/ | ||
| ZRangeWithScores(key string, rangeQuery options.ZRangeQueryWithScores) (map[Result[string]]Result[float64], error) |
There was a problem hiding this comment.
Can the map key be nil? If not then this should be `map[string]Result[float64].
There was a problem hiding this comment.
Never. This will be updated in another PR for all commands.
prateek-kumar-improving
approved these changes
Jan 10, 2025
Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #2878
Checklist
Before submitting the PR make sure the following are checked: