Go: Implement GetBit, SetBit, BitCount and Wait commands #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Comment on lines
+42
to
+44
| if options.Start == nil || options.End == nil { | ||
| return options, fmt.Errorf( | ||
| "SetBitmapIndexType value cannot be set without start and end values, use SetStart() and SetEnd()", |
There was a problem hiding this comment.
As an option you can create factory methods for BitCountOptions: BitCountOptionsWithStart, BitCountOptionsWithStartAndEnd, BitCountOptionsWithStartEndAndType or so. This will make API more aligned with others.
You can use builder pattern as an alternative.
There was a problem hiding this comment.
But I don't insist on changes.
Comment on lines
+81
to
+82
| // is The index offset type. Could be either {@link BitmapIndexType#BIT} or | ||
| // {@link BitmapIndexType#BYTE}. |
There was a problem hiding this comment.
Fix links (those are javadoc style)
Comment on lines
+14
to
+16
| // The offset is a zero-based index, with 0 being the first element of | ||
| // the list, 1 being the next element, and so on. The offset must be | ||
| // less than 2^32 and greater than or equal to 0 If a key is |
There was a problem hiding this comment.
Suggested change
| // The offset is a zero-based index, with 0 being the first element of | |
| // the list, 1 being the next element, and so on. The offset must be | |
| // less than 2^32 and greater than or equal to 0 If a key is | |
| // The offset is a zero-based index, with `0` being the first element of | |
| // the list, `1` being the next element, and so on. The offset must be | |
| // less than `2^32` and greater than or equal to `0` If a key is |
Consider copying docs from node client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go: Implement GetBit, SetBit, BitCount and Wait commands