Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GO: Implement Echo Command #2863

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

GO: Implement Echo Command #2863

wants to merge 8 commits into from

Conversation

EdricCua
Copy link
Collaborator

Issue link

This Pull Request is linked to issue (URL): [REPLACE ME]

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@EdricCua
Implement Echo Command
d08f61c 
Signed-off-by: EdricCua <[email protected]>
@EdricCua EdricCua requested a review from a team as a code owner December 24, 2024 08:45
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Dec 24, 2024
Yury-Fridlyand
Yury-Fridlyand reviewed Dec 24, 2024
View reviewed changes
go/api/commands.go Outdated Show resolved Hide resolved
go/api/commands.go Outdated Show resolved Hide resolved
go/api/base_client.go Outdated Show resolved Hide resolved
@prateek-kumar-improving
Copy link
Collaborator

Please update changelog.md file and update the checklist in the PR description.

@tjzhang-BQ
Copy link
Collaborator

linting check failed with a small spacing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjzhang-BQ tjzhang-BQ tjzhang-BQ left review comments

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EdricCua @prateek-kumar-improving @tjzhang-BQ @Yury-Fridlyand