Merge pull request #25 from siavash119/patch-1

Fix reply map value memory leak
valkey-io · Nov 7, 2024 · 898c3c8 · 898c3c8
2 parents a85254f + 06ccd5b
commit 898c3c8
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/reader.c b/src/reader.c
@@ -87,13 +87,13 @@ static void *tryParentize(const valkeyReadTask *task, PyObject *obj) {
                         Py_DECREF(obj);
                         return NULL;
                     }
-                    if (PyDict_SetItem(parent, self->pendingObject, obj) < 0) {
-                        Py_DECREF(obj);
-                        Py_DECREF(self->pendingObject);
-                        self->pendingObject = NULL;
+                    int x = PyDict_SetItem(parent, self->pendingObject, obj);
+                    Py_DECREF(obj);
+                    Py_DECREF(self->pendingObject);
+                    self->pendingObject = NULL;
+                    if (x < 0) {
                         return NULL;
                     }
-                    self->pendingObject = NULL;
                 }
                 break;
             case VALKEY_REPLY_SET: