Minor refactor, fix stuck syncs #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
darkdoc
commented
Jan 10, 2025
darkdoc
commented
- Lower the frequency of loading and generating image
- Refactor xray-init
- Refactor grafana
The image-generator downloads an image from validated-patterns-md-xray (vp public bucket) by default. This does not need to happen every second, for demo it is enough to generate an image once every 10 second.
|
/lgtm maybe let's fix those python linters before merging? |
Cleaned up syncwaves and hooks, jobs. We do not manually wait for resources to be up, we rely on argocd retries and eventual consistency. Improved bucket creation python script by adding some basic error handling and logging, also moved the script to its own file for better maintainability. Renamed xray-init to better reflect the true functionality of the app. Removed the unneeded service account application.
Cleaned up syncwaves and hooks, jobs. We do not manually wait for resources to be up, we rely on argocd retries and eventual consistency. Refactored the creation of prometheus datasource to a crd from a job. Removed all the unneeded rbac permissions from the sa. Added a consolelink for the grafana app for easier reachability since this is one of the main components of the pattern.
darkdoc
force-pushed
the
minor_refactor
branch
from
70426ef to
ea6af4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.