-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move product version declaration to base #1713
Merged
maximenoel8
merged 17 commits into
uyuni-project:master
from
maximenoel8:move_product_version_base
Oct 2, 2024
Merged
Move product version declaration to base #1713
maximenoel8
merged 17 commits into
uyuni-project:master
from
maximenoel8:move_product_version_base
Oct 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep handling product version at proxy and server level
maximenoel8
force-pushed
the
move_product_version_base
branch
from
October 2, 2024 01:20
91aae6b
to
cee960f
Compare
srbarrios
reviewed
Oct 2, 2024
meaksh
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's give it a try. Thanks!
srbarrios
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently in BV, we need to copy/paste for all modules ( server, proxy and minions ) the
product version
variable.The
product version
is always the same and don't bring information to minion or client modules.After discussion, we want to declare the product version to only one place and the best place seems to be at the base module level.
From my understanding, the product version is only useful for server, proxy and controller.
I didn't really find use case for the product version for minions / clients.
What does this PR change?
product version
declaration at base module level.product version
is going to be added to grain template at the host module level and not at the individual module level.product version
is not set at the individual module level.product version
at individual module level.Note: individual modules are modules like
modules/server/main.tf
,modules/minion/main.tf
,modules/proxy/main.tf
where base module ismodules/base/main.tf
and host module isbackend_modules/libvirt/host/main.tf
Other possibility
Declare the product version at the server level and use the the server_configuration to spread it to all other modules.
It will require more changes because the server_configuration variable is only declare in minion modules.