-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Ubuntu 24.04 #1707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I didn't check the urls and not sure if there's anything missing from another place but I don't think so.
d1386cb
to
a5dd96a
Compare
First tests show that the minion has its interface down:
Probably again a cloud-init pain... Will try to fix it tomorrow. |
5a39802
to
170b4cf
Compare
After a lot of fixes, it seems to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
5e44ea2
to
97fb916
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks !
97fb916
to
5bb02c8
Compare
Signed-off-by: Dominik Gedon <[email protected]>
5bb02c8
to
9683b05
Compare
What does this PR change?
This PR adds support for Ubuntu 24.04. Part of https://github.com/SUSE/spacewalk/issues/23851.
Follow-up of #1691 from @nodeg (Dominik being absent).
For technical reasons it replaces
packages:
withruncmd:
for cloud-init like in @srbarrios 's PR #1705.TODO
Links