Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless repository for RES 8 and add ubuntu2204 tools repo #1422

Merged

Conversation

maximenoel8
Copy link
Contributor

@maximenoel8 maximenoel8 commented Nov 15, 2023

What does this PR change?

To run the BV tests on AWS, we need the minion tool repositories. This list is the minimum you need to run the tests on AWS.
Update the minimum repository list to run BV on AWS with ubuntu2204 tool repo

Comment on lines -49 to -51
- url: http://download.suse.de/ibs/SUSE/Products/RES/8-CLIENT-TOOLS/x86_64/update/
archs: [x86_64]

Copy link
Member

@srbarrios srbarrios Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a package doesn't have any update, then the package will be only available in the Pool but not in the Updates channel.
Therefore, I'm not fully sure if we can rely only on Updates folder for RES8.

Copy link

@deneb-alpha deneb-alpha Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the point is more that the used URL is wrong...
http://download.suse.de/ibs/SUSE/Products/RES/8-CLIENT-TOOLS/x86_64/update/ -> this is a 404

the pool packages are at https://download.suse.de/ibs/SUSE/Products/RES/8-CLIENT-TOOLS/x86_64/product/

But I agree that we could have packages only in pool that are never updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so maybe the correct it will be to edit this line as:
url: http://download.suse.de/ibs/SUSE/Products/RES/8-CLIENT-TOOLS/x86_64/product/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is just a solution to have access to the default repositories needed for BV testing.
I just deploy BV on AWS using terraform and copy / paste the missing repositories in this list. The changes you are talking about are more related to salt/repos.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have my doubts this is correct, as in the case of introducing a new package dependency in the client tools, it will be only present on the "product" channel and not on the "updates" channels, at least until it receives an update. In such cases, this code will miss it.

@maximenoel8 maximenoel8 merged commit 6d387e3 into uyuni-project:master Nov 24, 2023
2 checks passed
@maximenoel8 maximenoel8 deleted the udpate_minimum_repository_list branch December 3, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants