Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server / proxy byos and paygo images support to sumaform #1418

Merged
merged 7 commits into from
Nov 26, 2023

Conversation

maximenoel8
Copy link
Contributor

What does this PR change?

Add support for new AWS images :

  • server BYOS
  • proxy BYOS
  • sles15sp5 paygo
  • server paygo

@maximenoel8 maximenoel8 changed the title Add server / proxy byos and paygo image support to sumaform Add server / proxy byos and paygo images support to sumaform Nov 23, 2023
packages: ["salt-minion"]

%{ endif }

%{ if image == "sles15sp5-paygo" || image == "sles12sp5-paygo" || image == "sap15sp5-paygo" }
packages: ["salt-minion"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can't follow the same strategy as others, include the corresponding repository, and install venv-salt-minion. Would that work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have public repository having venv-salt-minion package available for those distributions.
By default, those distributions have product repositories and salt-minion is available.
This salt-minion is only to run the sumaform highstate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using what is available by default will simplify our life on cloud public overall.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was more worry about the different salt paths and processes leftovers, using the same package we will reduce the leftovers because they will be overriden.
Anyway, approving.

@maximenoel8 maximenoel8 merged commit 79ea33c into uyuni-project:master Nov 26, 2023
2 checks passed
maximenoel8 added a commit to maximenoel8/sumaform that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants