-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server / proxy byos and paygo images support to sumaform #1418
Add server / proxy byos and paygo images support to sumaform #1418
Conversation
packages: ["salt-minion"] | ||
|
||
%{ endif } | ||
|
||
%{ if image == "sles15sp5-paygo" || image == "sles12sp5-paygo" || image == "sap15sp5-paygo" } | ||
packages: ["salt-minion"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can't follow the same strategy as others, include the corresponding repository, and install venv-salt-minion
. Would that work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have public repository having venv-salt-minion package available for those distributions.
By default, those distributions have product repositories and salt-minion is available.
This salt-minion is only to run the sumaform highstate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using what is available by default will simplify our life on cloud public overall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was more worry about the different salt paths and processes leftovers, using the same package we will reduce the leftovers because they will be overriden.
Anyway, approving.
What does this PR change?
Add support for new AWS images :