Load dependencies by name #1594
Open
+420
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fedotov, Aleksei <[email protected]>
Signed-off-by: Fedotov, Aleksei <[email protected]>
Signed-off-by: Fedotov, Aleksei <[email protected]>
Signed-off-by: Fedotov, Aleksei <[email protected]>
Signed-off-by: Fedotov, Aleksei <[email protected]>
Signed-off-by: Fedotov, Aleksei <[email protected]>
aleksei-fedotov
requested review from
pavelkumbrasev
and removed request for
pavelkumbrasev
egfefey
reviewed
Jan 9, 2025
CMakeLists.txt
Outdated
| message(WARNING | ||
| "Dependency signature verification during dynamic run-time linking is disabled. This may " | ||
| "lead to security vulnerabilities. It is recommended to leave it enabled in production " | ||
| "environment. Unset TBB_VERIFY_DEPENDENCY_SIGNATURE or set it ON to enable it again.") |
There was a problem hiding this comment.
Will unsetting TBB_VERIFY_DEPENDENCY_SIGNATURE not disable it instead? Did you mean "Set TBB_VERIFY_DEPENDENCY_SIGNATURE ..."
There was a problem hiding this comment.
I clarified the messaging.
egfefey
reviewed
Jan 9, 2025
src/tbb/dynamic_link.cpp
Outdated
| error = va_arg(args, dlerr_t); | ||
| // TODO: Use fprintf_s once dynamic link functionality is extracted into a separate | ||
| // module (e.g., a static library) | ||
| std::fprintf(stdout, "%s The module \"%s\" was not loaded because it was not found. " |
There was a problem hiding this comment.
Please look up and use the more secured version fprintf_s
egfefey
reviewed
Jan 9, 2025
src/tbb/dynamic_link.cpp
Outdated
| case dl_sys_fail: | ||
| str = va_arg(args, const char*); | ||
| error = va_arg(args, dlerr_t); | ||
| std::fprintf(stdout, "oneTBB: A call to \"%s\" failed with error " DLERROR_SPECIFIER |
There was a problem hiding this comment.
and all other locations of fprintf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies RFC:
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information