Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactors carousel #640

Merged
merged 6 commits into from
Dec 10, 2024
Merged

feat: refactors carousel #640

merged 6 commits into from
Dec 10, 2024

Conversation

mickeyhead7
Copy link
Collaborator

@mickeyhead7 mickeyhead7 commented Dec 3, 2024

Description

  • Refactors Carousel API
  • Updates docs
const MyComponent = () => (
  <Carousel activeItem={1}>
    <CarouselItems width={300}>
      <CarouselItem>
        <Box p="$2" aspectRatio={1.6} backgroundColor="$purple800">
          <Text color="$white">I'm a Carousel item!</Text>
        </Box>
      </CarouselItem>
      <CarouselItem>
        <Box p="$2" aspectRatio={1.6} backgroundColor="$red800">
          <Text color="$white">I'm another Carousel item!</Text>
        </Box>
      </CarouselItem>
    </CarouselItems>
    <CarouselPagination style={{ marginTop: 16 }} />
  </Carousel>
);

Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: 7225a28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@utilitywarehouse/native-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 10:38am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
native-ui ⬜️ Ignored (Inspect) Dec 10, 2024 10:38am
web-ui ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 10:38am

@mickeyhead7 mickeyhead7 force-pushed the feat/refactor-carousel-api branch from cdd8ac0 to 51afbb6 Compare December 3, 2024 11:53
Copy link
Contributor

github-actions bot commented Dec 3, 2024

🖥️ Native UI - Storybook Preview

Visit the Storybook preview URL to see the changes in action.

📱 Appetize Previews

You can view the apps using the link above and choosing the device from the top action bar. Alternatively, you can use the direct links below.


Last updated from commit 1104522

Copy link
Collaborator

@jordmccord jordmccord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jordmccord jordmccord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The show overflow doesn't seem to work in android... it did before...

@mickeyhead7 mickeyhead7 merged commit d231314 into main Dec 10, 2024
9 checks passed
@mickeyhead7 mickeyhead7 deleted the feat/refactor-carousel-api branch December 10, 2024 11:37
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants