Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Alert component #248

Merged
merged 26 commits into from
Mar 4, 2024
Merged

feat: Alert component #248

merged 26 commits into from
Mar 4, 2024

Conversation

jordmccord
Copy link
Collaborator

Adds the alert component to the Native UI library and documents to the Native UI storybook.

Screenshot 2024-02-29 at 15 12 43

@linear Linear
Copy link

linear bot commented Feb 29, 2024

UWDS-1870 Build Alert into the code library

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4f2ee54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
native-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 4:54pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
web-ui ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2024 4:54pm

@vercel vercel bot temporarily deployed to Preview – native-ui February 29, 2024 16:50 Inactive
noeliacabane
noeliacabane reviewed Mar 4, 2024
View reviewed changes
apps/native-ui-storybook/components/Alert/Variants.tsx Outdated
<AlertIcon as={InformationMediumContainedIcon} />
<AlertText>Unlock the power of knowledge with the following information.</AlertText>
</Alert>
<Alert colorScheme="success" mb={4} gap="$3">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question about this: should we add the margin button to each child or just a gap to the main container?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, I'd copied this over from the gluestack storybook but that's a good suggestion. Done!

noeliacabane
noeliacabane approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@noeliacabane noeliacabane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jordmccord jordmccord merged commit e42ea6e into main Mar 4, 2024
4 checks passed
@jordmccord jordmccord deleted the jmccord-uwds-1870 branch March 4, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noeliacabane noeliacabane noeliacabane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordmccord @noeliacabane