Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up matching district generation types #690

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Clean up matching district generation types #690

merged 1 commit into from
Jan 9, 2025

Conversation

vtnate
Copy link
Contributor

@vtnate vtnate commented Jan 2, 2025

Any background context you want to provide?

What does this PR accomplish?

  • Explicitly selects actions for 4th & 5th generation districts. Old technique was to assume that anything non-5th-gen was 4th gen. This enables additional generations of district systems to be modeled in the future, opening up development opportunities.
  • DRY up gmt.py a bit.

How should this be manually tested?

CI is suffcient

What are the relevant tickets?

Resolves #504

Screenshots (if appropriate)

@vtnate vtnate added the enhancement New feature or request label Jan 2, 2025
@vtnate vtnate self-assigned this Jan 2, 2025
@vtnate vtnate requested a review from nllong January 7, 2025 15:16
@vtnate vtnate merged commit cfe112c into develop Jan 9, 2025
8 checks passed
@vtnate vtnate deleted the issue504 branch January 9, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nllong nllong nllong approved these changes

Assignees

@vtnate vtnate

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Be explicit about which generation we're working with in the code
2 participants
@vtnate @nllong