Handle all-caps soil-temp stations, like Frankfurt #689
+17
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingWang-CUB
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
Some weather file names weren't being parsed correctly when looking up soil temp coefficients. Frankfurt was the first example we found of this. This handles those cases.
What does this PR accomplish?
If soil temp coeff lookup fails, try using only the first word of the station and capitalizing it. If that still doesn't work, error as before.
How should this be manually tested?
Build a demo project with the uo-cli, using with the Frankfurt weather file. Go through the default baseline workflow, and
uo_des create-model. If that works successfully (it did on my machine! 😄 ) we're good to goWhat are the relevant tickets?
Screenshots (if appropriate)