Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is_ghe_start_loop from test geojson files #688

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

vtnate
Copy link
Contributor

@vtnate vtnate commented Dec 26, 2024

Any background context you want to provide?

Removed is_ghe_start_loop from schema in urbanopt/urbanopt-geojson-gem#280 because it is how being handled automagically in ThermalNetwork.

What does this PR accomplish?

  • Remove this property from test geojson files

How should this be manually tested?

CI is sufficient

What are the relevant tickets?

Screenshots (if appropriate)

@vtnate vtnate self-assigned this Dec 26, 2024
@vtnate vtnate requested a review from JingWang-CUB January 2, 2025 15:34
Copy link
Collaborator

@JingWang-CUB JingWang-CUB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that we now automatically handle this flag inside ThermalNetwork.

@vtnate vtnate merged commit ad32d4d into develop Jan 2, 2025
8 checks passed
@vtnate vtnate deleted the ghe-start-loop branch January 2, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants