Support single building DES templates #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nllong
commented
Oct 25, 2024
| @@ -36,7 +36,7 @@ geojson = "^3.1" | |||
| jinja2 = "^3.1.2" | |||
| jsonpath-ng = "~1.6" | |||
| jsonschema = "~4.20" | |||
| modelica-builder = "^0.5.1" | |||
| modelica-builder = "^0.5.2rc3" | |||
There was a problem hiding this comment.
we should release 0.5.2 soon-ish
There was a problem hiding this comment.
I'd go so far as to say that if we merge my open PRs, we should go to 0.6.0. Agreed that should happen soon.
vtnate
reviewed
Oct 25, 2024
vtnate
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
For the constant and variable DES systems, if there was a single building, then the model would fail to build.
What does this PR accomplish?
If the jsonpath returns a dict, then it will assume it is a single building. This is not common, but needed for the aggregated load analysis.
How should this be manually tested?
unit tests should pass
What are the relevant tickets?
n/a
Screenshots (if appropriate)