-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privy #14822
Conversation
@@ -22,7 +22,7 @@ const Disconnect = ({ service }: DisconnectProps) => { | |||
|
|||
if (email) { | |||
userText = `User: ${email}` | |||
signOutText = 'Sign out' | |||
signOutText = 'Sign out now' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed :)
_render: { | ||
standalone: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what makes the privy load inside a component rather than as a modal.
locksmith/src/config/config.ts
Outdated
@@ -129,6 +129,9 @@ const config = { | |||
signerKeyBase64: process.env.APPLE_WALLET_SIGNER_KEY, | |||
wwdrBase64: process.env.APPLE_WALLET_WWDR_CERT, | |||
signerKeyPassphrase: process.env.APPLE_WALLET_SIGNER_KEY_PASSPHRASE, | |||
privyAppId: process.env.PRIVY_APP_ID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
necessary configs for privy on locksmith.
Description
A couple of months ago, we introduced Unlock Accounts 2.0 to improve our existing Unlock Accounts. At the time, the main goal was to add support for Google and Email magic links to existing passwords. For this we use Coinbase's wallet as a service... but they are deprecating this so we need to replace that.
We decided to go with Privy which offers a few benefits (mostly they manage everything so we don't have to worry about much), but that also presents 2 challenges:
_render: { standalone: true, }
option when loading it.Custom checklist:
A test plan for the newly integrated auth system, focusing on different authentication methods using Privy: