Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(unlock-app): Implement combobox Component for improved UX #14815

Merged
merged 7 commits into from
Oct 28, 2024

Conversation

0xTxbi
Copy link
Member

@0xTxbi 0xTxbi commented Oct 7, 2024

Description

This PR introduces changes that replace select elements with our new combobox component across the unlock-app. It enhances usability, especially when dealing with long or complex option lists, by providing dynamic search and quick filtering capabilities.

Flow

Loom

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • [] I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@0xTxbi 0xTxbi requested a review from julien51 October 7, 2024 09:17
@cla-bot cla-bot bot added the cla-signed label Oct 7, 2024
@0xTxbi 0xTxbi merged commit 6175837 into unlock-protocol:master Oct 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants