Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test deploy key push acess #197

Merged
merged 19 commits into from
Jan 23, 2025
Merged

Test deploy key push acess #197

merged 19 commits into from
Jan 23, 2025

Conversation

jordandsullivan
Copy link
Collaborator

No description provided.

jordandsullivan and others added 18 commits January 23, 2025 10:34
@jordandsullivan jordandsullivan mentioned this pull request Jan 23, 2025
Closed
Misty-W
Misty-W approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@Misty-W Misty-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks consistent with the solution comment on issue #191, which satisfies the key requirements:

  • automatic benchmarks
  • branch protection
  • benchmark results run and saved on main branch for consistency
    Benchmarks ran successfully on the dev branch, so LGTM!

@jordandsullivan jordandsullivan merged commit f47b1e7 into main Jan 23, 2025
1 check passed
@jordandsullivan jordandsullivan linked an issue Jan 23, 2025 that may be closed by this pull request
Requiring merge approvals breaks Actions #191
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Misty-W Misty-W Misty-W approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requiring merge approvals breaks Actions
3 participants
@jordandsullivan @Misty-W @actions-user