Remove compiled_data Default ctors from types which are prone to change sufficiently often #5958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
requested review from
sffc,
dminor,
zbraniecki and
a team
as code owners
Manishearth
force-pushed
the
default
branch
2 times, most recently
from
7c9116c to
e422c75
Compare
Manishearth
force-pushed
the
default
branch
2 times, most recently
from
9b6231b to
d4976cb
Compare
| - `icu_locale` | ||
| - `LocaleExpander`, `LocaleDirectionality`, and `LocaleCanonicalizer` distinguish between `new_common()` and `new_extended()` constructors (unicode-org#5958) | ||
| - `icu_segmenter` | ||
| - Segmenters that can take a content locale now specify `_root()` on their default localeless constructors (unicode-org#5958) |
There was a problem hiding this comment.
"root" is a CLDR term that we have so far avoided. I don't think it's very clear if you don't think of languages as a tree.
There was a problem hiding this comment.
Happy to bikeshed the names further.
#5856 (comment) has some discussion. I don't really like any of the names on the table.
There was a problem hiding this comment.
I dislike root for the same reason, it is CLDR jargon, however it is a relatively convenient name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clarifies a
new_common()vsnew_extended()distinction for locale data.Fixes #5554