-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/yarn-workspaces #103
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check travis build logs for graphicmagick
related error. Add it back to travis.yml if needed
before_install: | ||
- sudo apt-get update | ||
- sudo apt-get install graphicsmagick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need to install graphicsmagick for the image optimization task.
@@ -1,15 +1,14 @@ | |||
language: node_js | |||
|
|||
node_js: | |||
- "14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should consider adding multiple node versions here. Travis will do a build for each version listed. I think we should keep all LTS versions of node here. This way we can say we support LTS
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, let's go for 12.x
and 14.x
@robinloeffel , I forgot to bump the |
Robin Löffel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
yarn workspaces