Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added member name html character decoding to SignalR (issue #310) #318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

saitooo
Copy link

@saitooo saitooo commented Oct 10, 2018

Hi,

I did a few tests locally but wasn't able to verify this against the live forum. I hope this helps anyway.

@nul800sebastiaan
Copy link
Member

Hi @saitooo ! Can you help me understand what this does? How do I test this please? :-)

@bjarnef
Copy link
Contributor

bjarnef commented Oct 18, 2018

@nul800sebastiaan you can way until Anders Brohäll write a reply on Our 😅#310

Joke aside, you could check with another member write a reply with some special characters in the name. 👦

@nul800sebastiaan
Copy link
Member

Aha! I didn't see the issue number, gotcha!

@saitooo
Copy link
Author

saitooo commented Oct 19, 2018

@nul800sebastiaan Sorry about that, I could've linked the issue in my comment once more.

I've tried testing it when I signed up with my own account in your Umbraco, but I wasn't able to see the "<user> is working on a reply" in my attempts.

@nul800sebastiaan
Copy link
Member

Hi there @saitooo,

First of all: A big #H5YR for contributing to Umbraco during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🙏

If you haven't heard already we have had a record breaking amount of PR's in both the CMS and the Documentation repository. You can read all about the numbers in the Umbraco Hacktoberfest Aftermath blog post.

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

Receive your swag! 👈 Please follow this link to fill out and submit the form, before November 21st 2018.

Following this date we'll be sending out all the swag, which also means that it might not reach your doorstep before December, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The Umbraco PR Team & The Documentation Curators

@nul800sebastiaan nul800sebastiaan changed the base branch from master to main July 15, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants