-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing multimaterial json #136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #136 +/- ##
==========================================
Coverage ? 91.44%
==========================================
Files ? 3
Lines ? 538
Branches ? 0
==========================================
Hits ? 492
Misses ? 46
Partials ? 0
Continue to review full report at Codecov.
|
…nics_material_maker into changing_multimaterial_json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relating to recent issues #135 #134 #133 #129
This PR improves and simplifies the code in a few ways. In general there were some cases where the user could do things in a couple of different ways and it would not be clear which was the final output.
For example:
Removes unused keys in the database for
packable
andenrichable
Removes density_equation attribute and allows density to accept a string input which is evaluated as an equation
Adds the
nmm.Material.from_library()
method for clearing making materials from the internal dictionary / database. This can be extented to be enhanced in the future regarding which database to retrieve.Removes
MultiMaterial()
class and replaces it withnmm.Material.from_mixutre()
TODO