-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cryostat docs #3501
Draft
chris-ashe
wants to merge
14
commits into
main
Choose a base branch
from
update_cryostat_docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update cryostat docs #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or clarity and consistency
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3501 +/- ##
=======================================
Coverage 30.31% 30.32%
=======================================
Files 80 80
Lines 19534 19537 +3
=======================================
+ Hits 5922 5924 +2
- Misses 13612 13613 +1 ☔ View full report in Codecov by Sentry. |
…n documentation and code
…in documentation and code
…tion and cryostat volume section for improved clarity
chris-ashe
force-pushed
the
update_cryostat_docs
branch
from
January 27, 2025 15:14
ff8c516
to
327bb37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes to the naming conventions for cryostat-related variables across multiple files, ensuring consistency and clarity in the codebase. The most important changes involve renaming variables and updating documentation to reflect these changes.
🔄 Namespace changes
Variables
rdewex
->r_cryostat_inboard
rpf2dewar
->dr_pf_cryostat
hcryopf
->dz_pf_cryostat
zdewex
->dz_cryostat_half_inside
vdewex
->vol_cryostat
ddwex
->dr_cryostat
clhsf
->f_z_cryostat
clh1
->dz_tf_cryostat
🐛 Bugs
Which wasnt easy to interpret so a new model for the cryostat structure volume has been introduced which is simply$m^3$ )
dividing the cryostat into 2 nested cylinders and taking the internal volume from the bigger one. This caused a 1% change in the calculated volume compared to the tests (
810 -> 818
Checklist
I confirm that I have completed the following checks: