Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long forecast SFS Regression Test #2478

Conversation

LarissaReames-NOAA
Copy link
Collaborator

@LarissaReames-NOAA LarissaReames-NOAA commented Oct 22, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

I've added a new RT for a long forecast (360 days) of the SFS configuration. To enable this (and avoid the problems discovered in #2320), CICE_PIO is now configurable at compile time instead of hard-coded in CICE-interface/CMakeLists.txt as a cmake flag DCICE_PIO. The default remains "PIO" which is how it was hard-coded previously.

Full RT suite completed on Hera. See log here: /scratch1/BMC/gsd-fv3/Larissa.Reames/ufs-weather-model/tests/logs/log_hera_save/workflow.log

Commit Message:

* UFSWM - Added long SFS RT. Made CICE_PIO configurable at compile time but maintains default "PIO" behavior.

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

  • PR Adds New Tests/Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@LarissaReames-NOAA LarissaReames-NOAA marked this pull request as ready for review October 22, 2024 15:39
@LarissaReames-NOAA LarissaReames-NOAA marked this pull request as draft October 22, 2024 15:40
…ccpp-framework) for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py ) ufs-community#2464 + Update chunksizes for cubed sphere grid ufs-community#2465 (ufs-community#2463)

* UFSWM - 
  Update LND I/O docs
  Add fd_ufs.yaml docs
  Add tests-dev docs
* UFSWM - Change the default chunking for the cubed sphere history files to use only the horizontal grid size of each of the tiles.
   * FV3 - Change the default chunking for the cubed sphere history files to use only the horizontal grid size of each of the tiles.
   * FV3 - Submodule pointer update for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py)

---------

Co-authored-by: Dusan Jovic <[email protected]>
Co-authored-by:  Dom Heinzeller <[email protected]>
Comment on lines 50 to 52
OCN_tasks=$OCN_tasks_cpl_bmrk
ICE_tasks=$ICE_tasks_cpl_bmrk
WAV_tasks=0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LarissaReames-NOAA you may want to export these. If I understand, turning off wave is cheaper but then this configuration is more of a nowave_noaero test

It may also be worth adding more files to the baseline in LIST_FILES (CICE, history files,...) if this would be running anyways

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed these to export. Also, I believe the plan now is to go without waves for SFS tests until we're at a finer grid, hence why I turned these off.

* UFSWM - Modify global_control.nml to add compatibility with Global Workflow
LarissaReames-NOAA and others added 10 commits November 5, 2024 15:16
…fs-community#2475)

* UFSWM - Updates cpld_control_sfs to use the most up-to-date configuration specs
* UFSWM - Update units attributes in netCDF output to be machine-readable
  * FV3 - Update units attributes in netCDF output to be machine-readable
    * atmos_cubed_sphere - Update units attributes in netCDF output to be machine-readable
…n PR from production/RRFS.v1 ufs-community#2481 (ufs-community#2458)

* UFSWM - Enable some of the intel llvm tests in rt conf
* UFSWM - Second reconciliation PR from production/RRFS.v1 related to FV3 unused and optional variables
  * FV3 - Second reconciliation PR from production/RRFS.v1 related to FV3 unused and optional variables
    * ccpp-physics - Second reconciliation PR from production/RRFS.v1 related to FV3 unused and optional variables

---------

Co-authored-by: Grant Firl <[email protected]>
… CAPE cases + ufs-community#2459 (ufs-community#2461)

* UFSWM - Add tests-dev ATM-only idealized dry baroclinic wave test and a 2020 July CAPE case
* UFSWM - Update modulefile to support Rocky 8 on CSPs, with ParallelWorks

---------

Co-authored-by: Wei Huang <[email protected]>
Co-authored-by: Jong Kim <[email protected]>
* UFSWM - add PIO settings to WAV attributes in ufs.configure templates
* UFSWM - update ww3_shel.nml to allow for the ice field to be written to the restart file when required (i.e, waves in the slow loop)
* UFSWM - add WW3 restart files to comparison lists
  * WW3 - Add netCDF PIO capability for restarts and run-time history
* UFSWM 
  * FV3
    * ccpp-physics - Add Incremental Analysis Update (IAU) capability to update soil temperature and moisture for CCPP's NoahMP land model
…-community#2498 (ufs-community#2489)

* UFSWM - Documentation for HSD cases 
  * FV3 - 
    * upp - update upp hash to ce258fca with update inline post interface. 

---------

Co-authored-by: gspetro-NOAA <[email protected]>
Co-authored-by: cameronbook <[email protected]>
* UFSWM - Thompson-Eidhammer microphysics code formatting
  * FV3 - Thompson-Eidhammer microphysics code formatting
    * ccpp-physics - Thompson-Eidhammer microphysics code formatting
)

* UFSWM - Update CICE to Consortium/main (2024-11). Expose hist_suffix for CICE ice_in
  * CICE - Update CICE to Consortium/main (2024-11)
@LarissaReames-NOAA LarissaReames-NOAA deleted the feature/sfs_RT branch December 5, 2024 15:56
@LarissaReames-NOAA LarissaReames-NOAA restored the feature/sfs_RT branch December 5, 2024 15:56
@LarissaReames-NOAA
Copy link
Collaborator Author

Closed and will re-open with a cleaner branch. This one got muddled when trying to go back and remove changes that are no longer needed after the CICE fix.

@LarissaReames-NOAA LarissaReames-NOAA deleted the feature/sfs_RT branch December 5, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CICE PIO compile optionally replaceable by NetCDF compile in RTs
10 participants