Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PIO namelist control for CICE #2145

Merged
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
67753b7
initial commit of new variables
DeniseWorthen Feb 13, 2024
bfbc578
fix ice_in issues
DeniseWorthen Feb 13, 2024
efd0a62
update CICE, fix more variables
DeniseWorthen Feb 13, 2024
f574f79
Merge branch 'ufs-community:develop' into feature/pio_options
DeniseWorthen Feb 13, 2024
8d2d303
Merge branch 'ufs-community:develop' into feature/pio_options
DeniseWorthen Feb 22, 2024
91eee4d
update CICE submodule
DeniseWorthen Feb 22, 2024
ad1496c
switch to using pnetcdf5 by default
DeniseWorthen Feb 22, 2024
1c0c29c
Merge branch 'ufs-community:develop' into feature/pio_options
DeniseWorthen Feb 26, 2024
43202a0
switch to pnetcdf2 by default
DeniseWorthen Feb 26, 2024
8334c29
Merge branch 'develop' into feature/pio_options
DeniseWorthen Mar 13, 2024
805da31
Merge branch 'ufs-community:develop' into feature/pio_options
DeniseWorthen Mar 24, 2024
9105292
Merge branch 'develop' into feature/pio_options
DeniseWorthen Apr 3, 2024
9493502
Merge branch 'develop' into feature/pio_options
DeniseWorthen Apr 4, 2024
3c7661b
add test_changes.list
DeniseWorthen Apr 4, 2024
c27cfcc
detabify ice_in.IN
DeniseWorthen Apr 5, 2024
f08cc43
Merge branch 'ufs-community:develop' into feature/pio_options
DeniseWorthen Apr 5, 2024
2961eb0
update CICE
DeniseWorthen Apr 7, 2024
6c889ca
Update bl_date.conf
FernandoAndrade-NOAA Apr 8, 2024
15c446f
add derecho RT logs: passed
zach1221 Apr 9, 2024
408e670
add hercules RT logs: passed
zach1221 Apr 9, 2024
67ea1ab
add orion RT logs: passed
zach1221 Apr 9, 2024
5c8292d
add control_p8 ORT logs: passed
zach1221 Apr 9, 2024
8aa4063
add regional_control ORT logs: passed
zach1221 Apr 9, 2024
1bf7851
add cpld_control ORT logs: passed
zach1221 Apr 9, 2024
46ef244
add gaea RT log passed
FernandoAndrade-NOAA Apr 9, 2024
5efb5c1
add jet RT log passed
FernandoAndrade-NOAA Apr 10, 2024
edb7280
Acorn RT Log: Passed
BrianCurtis-NOAA Apr 10, 2024
59a668f
add hera RT log pass
FernandoAndrade-NOAA Apr 10, 2024
66e4a88
WCOSS2 RT Log: Passed and Temp workaround to use hdf5 on WCOSS2 for CICE
BrianCurtis-NOAA Apr 11, 2024
c501d86
update CICE and revert gitmodules
DeniseWorthen Apr 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,10 @@
branch = dev/emc
[submodule "CICE"]
path = CICE-interface/CICE
url = https://github.com/NOAA-EMC/CICE
branch = emc/develop
#url = https://github.com/NOAA-EMC/CICE
#branch = emc/develop
url = https://github.com/DeniseWorthen/CICE
branch=feature/pio_options
[submodule "CDEPS"]
path = CDEPS-interface/CDEPS
url = https://github.com/NOAA-EMC/CDEPS
Expand Down
2 changes: 1 addition & 1 deletion CICE-interface/CICE
Submodule CICE updated 70 files
+1 −1 .github/PULL_REQUEST_TEMPLATE.md
+4 −2 .github/workflows/test-cice.yml
+16 −4 cicecore/cicedyn/analysis/ice_history.F90
+14 −8 cicecore/cicedyn/analysis/ice_history_shared.F90
+19 −3 cicecore/cicedyn/dynamics/ice_dyn_eap.F90
+52 −11 cicecore/cicedyn/dynamics/ice_dyn_evp.F90
+104 −10 cicecore/cicedyn/dynamics/ice_dyn_shared.F90
+12 −19 cicecore/cicedyn/dynamics/ice_dyn_vp.F90
+29 −112 cicecore/cicedyn/dynamics/ice_transport_remap.F90
+2 −1 cicecore/cicedyn/general/ice_flux.F90
+9 −1 cicecore/cicedyn/general/ice_forcing.F90
+247 −56 cicecore/cicedyn/general/ice_init.F90
+2 −0 cicecore/cicedyn/general/ice_state.F90
+27 −18 cicecore/cicedyn/infrastructure/comm/mpi/ice_global_reductions.F90
+27 −18 cicecore/cicedyn/infrastructure/comm/serial/ice_global_reductions.F90
+27 −27 cicecore/cicedyn/infrastructure/ice_blocks.F90
+45 −34 cicecore/cicedyn/infrastructure/ice_domain.F90
+50 −141 cicecore/cicedyn/infrastructure/ice_grid.F90
+2 −1 cicecore/cicedyn/infrastructure/ice_memusage.F90
+636 −655 cicecore/cicedyn/infrastructure/ice_read_write.F90
+1 −1 cicecore/cicedyn/infrastructure/ice_restoring.F90
+1 −0 cicecore/cicedyn/infrastructure/io/io_binary/ice_history_write.F90
+12 −12 cicecore/cicedyn/infrastructure/io/io_binary/ice_restart.F90
+1,032 −1,061 cicecore/cicedyn/infrastructure/io/io_netcdf/ice_history_write.F90
+256 −207 cicecore/cicedyn/infrastructure/io/io_netcdf/ice_restart.F90
+656 −535 cicecore/cicedyn/infrastructure/io/io_pio2/ice_history_write.F90
+156 −65 cicecore/cicedyn/infrastructure/io/io_pio2/ice_pio.F90
+589 −541 cicecore/cicedyn/infrastructure/io/io_pio2/ice_restart.F90
+32 −1 cicecore/drivers/nuopc/cmeps/ice_comp_nuopc.F90
+44 −34 cicecore/drivers/nuopc/cmeps/ice_import_export.F90
+1 −7 cicecore/drivers/nuopc/cmeps/ice_mesh_mod.F90
+1 −1 cicecore/drivers/standalone/cice/CICE_InitMod.F90
+9 −2 cicecore/shared/ice_restart_shared.F90
+13 −0 configuration/scripts/ice_in
+6 −1 configuration/scripts/machines/Macros.conda_macos
+2 −0 configuration/scripts/machines/env.derecho_cray
+2 −0 configuration/scripts/machines/env.derecho_gnu
+2 −0 configuration/scripts/machines/env.derecho_intel
+2 −0 configuration/scripts/machines/env.derecho_intelclassic
+2 −0 configuration/scripts/machines/env.derecho_inteloneapi
+2 −0 configuration/scripts/machines/env.derecho_nvhpc
+1 −0 configuration/scripts/machines/environment.yml
+1 −0 configuration/scripts/options/set_env.iopio1
+0 −1 configuration/scripts/options/set_env.iopio1p
+0 −1 configuration/scripts/options/set_env.iopio2p
+1 −0 configuration/scripts/options/set_nml.histall
+1 −0 configuration/scripts/options/set_nml.histdbg
+2 −0 configuration/scripts/options/set_nml.iobinary
+2 −0 configuration/scripts/options/set_nml.iocdf1
+2 −0 configuration/scripts/options/set_nml.iocdf2
+2 −0 configuration/scripts/options/set_nml.iocdf5
+2 −0 configuration/scripts/options/set_nml.iohdf5
+4 −0 configuration/scripts/options/set_nml.iohdf5opts
+0 −2 configuration/scripts/options/set_nml.iopio1
+0 −2 configuration/scripts/options/set_nml.iopio1p
+0 −2 configuration/scripts/options/set_nml.iopio2
+0 −2 configuration/scripts/options/set_nml.iopio2p
+10 −0 configuration/scripts/options/set_nml.iopioopts
+2 −0 configuration/scripts/options/set_nml.iopnetcdf1
+2 −0 configuration/scripts/options/set_nml.iopnetcdf2
+2 −0 configuration/scripts/options/set_nml.iopnetcdf5
+3 −3 configuration/scripts/tests/gridsys_suite.ts
+41 −67 configuration/scripts/tests/io_suite.ts
+13 −0 doc/source/cice_index.rst
+8 −2 doc/source/developer_guide/dg_about.rst
+3 −1 doc/source/developer_guide/dg_infra.rst
+51 −14 doc/source/user_guide/ug_case_settings.rst
+97 −29 doc/source/user_guide/ug_implementation.rst
+65 −18 doc/source/user_guide/ug_running.rst
+5 −0 doc/source/user_guide/ug_testing.rst
2 changes: 1 addition & 1 deletion CICE-interface/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ else()
endif()

# Configuration Options
set(CICE_IO "NetCDF" CACHE STRING "CICE OPTIONS: Choose IO options.")
set(CICE_IO "PIO" CACHE STRING "CICE OPTIONS: Choose IO options.")
set_property(CACHE CICE_IO PROPERTY STRINGS "NetCDF" "PIO" "Binary")

# Too many files to list, so include them via this file
Expand Down
18 changes: 18 additions & 0 deletions tests/default_vars.sh
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,24 @@ export CICE_RUNID=unknown
export CICE_USE_RESTART_TIME=.false.
export CICE_RESTART_DIR=./RESTART/
export CICE_RESTART_FILE=iced

export CICE_RESTART_FORMAT='pnetcdf2'
export CICE_RESTART_IOTASKS=-99
export CICE_RESTART_REARR='box'
export CICE_RESTART_ROOT=-99
export CICE_RESTART_STRIDE=-99
export CICE_RESTART_CHUNK=0,0
export CICE_RESTART_DEFLATE=0

export CICE_HISTORY_FORMAT='pnetcdf2'
export CICE_HISTORY_IOTASKS=-99
export CICE_HISTORY_REARR='box'
export CICE_HISTORY_ROOT=-99
export CICE_HISTORY_STRIDE=-99
export CICE_HISTORY_CHUNK=0,0
export CICE_HISTORY_DEFLATE=0
export CICE_HISTORY_PREC=4

export CICE_DUMPFREQ=d
export CICE_DUMPFREQ_N=1000
export CICE_DIAGFREQ=`expr $FHMAX \* 3600 / $DT_CICE`
Expand Down
101 changes: 57 additions & 44 deletions tests/parm/ice_in.IN
Original file line number Diff line number Diff line change
@@ -1,48 +1,61 @@
&setup_nml
days_per_year = 365
use_leap_years = .true.
year_init = @[SYEAR]
month_init = @[SMONTH]
day_init = @[SDAY]
sec_init = @[SECS]
dt = @[DT_CICE]
npt = @[CICE_NPT]
ndtd = 1
runtype = '@[CICE_RUNTYPE]'
runid = '@[CICE_RUNID]'
ice_ic = 'cice_model.res.nc'
restart = .true.
restart_ext = .false.
use_restart_time = @[CICE_USE_RESTART_TIME]
restart_format = 'nc'
lcdf64 = .false.
numin = 21
numax = 89
restart_dir = '@[CICE_RESTART_DIR]'
restart_file = '@[CICE_RESTART_FILE]'
pointer_file = './ice.restart_file'
dumpfreq = '@[CICE_DUMPFREQ]'
dumpfreq_n = @[CICE_DUMPFREQ_N]
dump_last = .false.
bfbflag = 'off'
diagfreq = @[CICE_DIAGFREQ]
diag_type = 'file'
diag_file = 'ice_diag.d'
print_global = .true.
print_points = .true.
latpnt(1) = 90.
lonpnt(1) = 0.
latpnt(2) = -65.
lonpnt(2) = -45.
histfreq = 'm','d','h','x','x'
histfreq_n = @[CICE_HISTFREQ_N]
hist_avg = @[CICE_HIST_AVG]
history_dir = '@[CICE_HISTORY_DIR]'
history_file = 'iceh'
write_ic = .true.
incond_dir = '@[CICE_INCOND_DIR]'
incond_file = 'iceh_ic'
version_name = 'CICE_6.0.2'
days_per_year = 365
use_leap_years = .true.
year_init = @[SYEAR]
month_init = @[SMONTH]
day_init = @[SDAY]
sec_init = @[SECS]
dt = @[DT_CICE]
npt = @[CICE_NPT]
ndtd = 1
runtype = '@[CICE_RUNTYPE]'
runid = '@[CICE_RUNID]'
ice_ic = 'cice_model.res.nc'
restart = .true.
restart_ext = .false.
use_restart_time = @[CICE_USE_RESTART_TIME]
numin = 21
numax = 89
restart_format = '@[CICE_RESTART_FORMAT]'
restart_iotasks = @[CICE_RESTART_IOTASKS]
restart_rearranger = '@[CICE_RESTART_REARR]'
restart_root = @[CICE_RESTART_ROOT]
restart_stride = @[CICE_RESTART_STRIDE]
restart_chunksize = @[CICE_RESTART_CHUNK]
restart_deflate = @[CICE_RESTART_DEFLATE]
restart_dir = '@[CICE_RESTART_DIR]'
restart_file = '@[CICE_RESTART_FILE]'
pointer_file = './ice.restart_file'
dumpfreq = '@[CICE_DUMPFREQ]'
dumpfreq_n = @[CICE_DUMPFREQ_N]
dump_last = .false.
bfbflag = 'off'
diagfreq = @[CICE_DIAGFREQ]
diag_type = 'file'
diag_file = 'ice_diag.d'
print_global = .true.
print_points = .true.
latpnt(1) = 90.
lonpnt(1) = 0.
latpnt(2) = -65.
lonpnt(2) = -45.
history_format = '@[CICE_HISTORY_FORMAT]'
history_iotasks = @[CICE_HISTORY_IOTASKS]
history_rearranger = '@[CICE_HISTORY_REARR]'
history_root = @[CICE_HISTORY_ROOT]
history_stride = @[CICE_HISTORY_STRIDE]
history_chunksize = @[CICE_HISTORY_CHUNK]
history_deflate = @[CICE_HISTORY_DEFLATE]
history_precision = @[CICE_HISTORY_PREC]
histfreq = 'm','d','h','x','x'
histfreq_n = @[CICE_HISTFREQ_N]
hist_avg = @[CICE_HIST_AVG]
history_dir = '@[CICE_HISTORY_DIR]'
history_file = 'iceh'
write_ic = .true.
incond_dir = '@[CICE_INCOND_DIR]'
incond_file = 'iceh_ic'
version_name = 'CICE_6.0.2'
/

&grid_nml
Expand Down
14 changes: 9 additions & 5 deletions tests/test_changes.list
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
hafs_regional_atm_ocn intel
hafs_regional_docn intel
hafs_regional_docn_oisst intel
control_p8_atmlnd intel
control_restart_p8_atmlnd intel
cpld_control_gfsv17_iau intel
cpld_control_ciceC_p8 intel
cpld_control_c192_p8 intel
cpld_restart_c192_p8 intel
cpld_control_c48 intel
datm_cdeps_ciceC_cfsr intel
datm_cdeps_mx025_cfsr intel
datm_cdeps_mx025_gefs intel
cpld_control_nowave_noaero_p8 gnu
Loading