-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] [bug fix] Adding missing Intel variable for PW Azure #1167
[develop] [bug fix] Adding missing Intel variable for PW Azure #1167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me! I see from the nightly build that both the Functional WorkflowTaskTests and Test phases successfully passed.
I ran the fundamental tests on Hera and they all passed:
----------------------------------------------------------------------------------------------------
Experiment name | Status | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2 COMPLETE 18.91
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20241 COMPLETE 11.41
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot COMPLETE 30.72
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024121 COMPLETE 56.96
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20241211145 COMPLETE 32.22
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024121114570 COMPLETE 57.89
----------------------------------------------------------------------------------------------------
Total COMPLETE 208.11
Additionally, the Functional WorkflowTaskTests script was also run on Hera and successfully passed:
# Try hera with the first few simple SRW tasks ...
run_make_grid: COMPLETE
run_get_ics: COMPLETE
run_get_lbcs: COMPLETE
run_make_orog: COMPLETE
run_make_sfc_climo: COMPLETE
run_make_ics: COMPLETE
run_make_lbcs: COMPLETE
run_fcst: COMPLETE
run_post: COMPLETE
Approving this PR now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, approved.
There are currently issues with the documentation that has nothing to do with the changes you have made. I'll need to open a PR in your fork to address a site redirect. There is also an issue with the NCEP site currently being down. I have opened PR #2 in your fork to address the site redirect. I'll wait until the issue with the NCEP site has been addressed, then I will merge this work. |
[pw-azure-bug-fix] Add redirect for https://mrms.ncep.noaa.gov in doc/conf.py
After discussing with @gspetro-NOAA, I will merge this work to develop now and will check if https://www.ncep.noaa.gov properly loads in the morning. This will lead to a red X on develop, but again, it should clear up by the morning (hopefully). |
DESCRIPTION OF CHANGES:
The SRW App still fails on the PW Azure instance. It appears that the compute node needs to be in the same zone as the controller node. To achieve this, the compute node instance type needs to change, which is failing because of a missing intel variable. This PR adds this missing intel variable when running on Azure.
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
DOCUMENTATION:
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):