Add MEGAN2 BVOC emission process #111
Open
+2,905
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TChem into feature/catchem_begins
zmoon
reviewed
Jan 6, 2025
Comment on lines
+51
to
+52
| CO2_Inhib_Opt: true | ||
| CO2_conc_ppm: 390.0 |
There was a problem hiding this comment.
I think thus far we've been trying to keep keys all lowercase?
Comment on lines
+3
to
+9
| !! \brief Contains MEGAN2.1 biogenic VOC emission Scheme based on HEMCO and Sam Silva's canopy edits | ||
| !! | ||
| !! Reference: | ||
| !! (1) Guenther et al, (GMD 2012) and associated MEGANv2.1 source code | ||
| !! https://doi.org/10.5194/gmd-5-1471-2012 | ||
| !! (2) Sam Silva's simplified canopy edits (GMD 2020) | ||
| !! https://doi.org/10.5194/gmd-13-2569-2020 |
There was a problem hiding this comment.
Does this incorporate any of Guenther's standalone MEGAN2.1 code mentioned here? Or is it more based on HEMCO's MEGAN2.1 implementation (in which case HEMCO references and links to GitHub or Zenodo could be added)? And to what extent does Silva's surrogate MEGAN3 come in here?
@zmoon Do you mean the warning below? I am not sure how it happens. Could you help me get rid of it? CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required): Compatibility with CMake < 3.10 will be removed from a future version of CMake. Update the VERSION argument value or use a ... suffix to tell CMake that the project does not need compatibility with older versions. |
Not that one, we can address that later, it's not related to your PR. I was talking about the warnings from the compiler: For example with gfortran-11 |
Oh ok. It seems to have some unused variables. I can clean them. But I guess we should keep the unused 'chemstate' and 'diagstate' for future use? |
If it's something you are reasonably sure may be used in the future, you can comment the declaration out instead of fully removing it (but still remove it from arguments if necessary to resolve the warning). And if you have "equality comparison for real" warning, you can use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the MEGAN2.1 BVOC emission scheme based on its implementation in HEMCO.