This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
feat: read from env #639
Merged
feat: read from env #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
whilefoo
suggested changes
Aug 20, 2023
There was a problem hiding this comment.
Because we are reading from env I think it's better to put these variables in the loadConfig but leave the default values in this file
|
Doesn't load config function return object of type bot config or am I getting confused |
|
yes but this is internal bot config, not like ubiquibot-config.yaml |
|
i didnt exactly understand the spec |
whilefoo
suggested changes
Aug 23, 2023
whilefoo
suggested changes
Aug 25, 2023
whilefoo
approved these changes
Aug 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #619