chore: exclude files with empty strings checker

[obeys]

Resolves #82

Changes:

• Added the ability to pass file paths to no-empty-strings.yml
• Changed empty-string-checker.ts to take in file paths from the workflow
• If the current file matches one excluded files it skips the file

QA:

• Repo
• Action

How to QA and setup:

• Create a file with empty strings
• Add the file to no-empty-strings.yml EXCLUDED_FILES
• Run Action

[ubiquity-os-deployer]

f97330e

53adeb4

9d2754e

78c59b5

573872f

1d6e41b

[obeys]

@rndquu could you maybe look at this, unsure why no reviewer was assigned 🤔

[rndquu]

Check this PR which introduces an empty string and passes empty strings check CI while the expected behavior for the CI to fail.

[obeys]

@rndquu I believe that the reason the CI passed was because you used single quote strings ('') which was not detected by the regex.

Normally from what i've figured the linter would convert all the single quote strings to double quotes which would've been detected by the CI. I've changed the regex so it would match single quote strings, but that made it so the regex itself would also be detected and I know you wanted me to remove the default value from EXCLUDED_FILES.

Here's the CI https://github.com/wellneverknow/ts-template/actions/runs/12089305564
and PR: wellneverknow#3

I can either:

1. Add .github/empty-string-checker.ts back to EXCLUDED_FILES so the regex wouldn't fail the CI
2. keep the old regex which only matches double quotes ("") which should detect empty strings as long as someone doesn't push without ignoring the linter.

Let me know which works best for you!

[ubiquity-os]

@obeys, this task has been idle for a while. Please provide an update.

[obeys]

waiting on @rndquu

[rndquu]

Check this PR which assigns an empty string to a variable.

Now check this commit which removes the EXCLUDED_FILES env variable. The empty string CI check is passed for that commit although the expected behavior for the CI to fail since the EXCLUDED_FILES env variable is no longer set.

[rndquu]

@rndquu I believe that the reason the CI passed was because you used single quote strings ('') which was not detected by the regex.

Normally from what i've figured the linter would convert all the single quote strings to double quotes which would've been detected by the CI. I've changed the regex so it would match single quote strings, but that made it so the regex itself would also be detected and I know you wanted me to remove the default value from EXCLUDED_FILES.

Here's the CI https://github.com/wellneverknow/ts-template/actions/runs/12089305564 and PR: wellneverknow#3

I can either:

1. Add .github/empty-string-checker.ts back to EXCLUDED_FILES so the regex wouldn't fail the CI
2. keep the old regex which only matches double quotes ("") which should detect empty strings as long as someone doesn't push without ignoring the linter.

Let me know which works best for you!

You may keep the old regex which only matches double quotes (""), this task for excluding certain files from the CI check

[obeys]

Check this PR which assigns an empty string to a variable.

Now check this commit which removes the EXCLUDED_FILES env variable. The empty string CI check is passed for that commit although the expected behavior for the CI to fail since the EXCLUDED_FILES env variable is no longer set.

I've added EXCLUDED_FILES to the initial required environment variables check so the CI now will fail.

Here's a check failing because EXCLUDED_FILES was not found
Here's another check failing because EXCLUDED_FILES was found but there was an empty string in main.ts

[obeys]

@rndquu EXCLUDED_FILES is now optional and there's no empty strings in empty-string-checker.ts