Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use sonarjs legacy eslint rules #86

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix: use sonarjs legacy eslint rules #86

merged 1 commit into from
Nov 26, 2024

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Nov 26, 2024

Resolves #82 (comment)

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Nov 26, 2024 •
edited
Loading

@rndquu rndquu marked this pull request as ready for review November 26, 2024 07:28
@rndquu rndquu mentioned this pull request Nov 26, 2024
Closed
@gentlementlegen
Copy link
Member

I believe that's fine as a short term fix, but I think we should update eslint to v9 like we did in the plugins template.

@rndquu
Copy link
Member Author

rndquu commented Nov 26, 2024

I believe that's fine as a short term fix, but I think we should update eslint to v9 like we did in the plugins template.

#87

@rndquu rndquu merged commit b7f0579 into ubiquity:development Nov 26, 2024
4 checks passed
@rndquu rndquu deleted the fix/eslint-sonarjs branch November 26, 2024 07:52
@ubiquity-os ubiquity-os
Copy link

ubiquity-os bot commented Dec 9, 2024

@obeys, this task has been idle for a while. Please provide an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gentlementlegen gentlementlegen gentlementlegen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty String Check workflow: exclude files
2 participants
@rndquu @gentlementlegen