Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update knip-reporter.yml #60

Closed
wants to merge 1 commit into from
Closed

Update knip-reporter.yml #60

wants to merge 1 commit into from

Conversation

0x4007
Copy link
Member

@0x4007 0x4007 commented Oct 1, 2024

Noticed this here https://github.com/0x4007/typescript-action/pull/3/files#diff-e300da0383d00d275266a83902a2aff8c7f62da696de4bc47ca5810e69c01ffeR9

The context is that I am building a brand new plugin template, and I started by:

  1. Using GitHub's official "TypeScript Action Starter Template"
  2. Pulling in our ts-template
  3. Finally pulling in our plugin-template

Is this required?

@0x4007 0x4007 requested a review from gitcoindev October 1, 2024 06:00
@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Oct 1, 2024

@0x4007 0x4007 requested a review from rndquu October 1, 2024 06:43
@rndquu
Copy link
Member

rndquu commented Oct 1, 2024

Noticed this here https://github.com/0x4007/typescript-action/pull/3/files#diff-e300da0383d00d275266a83902a2aff8c7f62da696de4bc47ca5810e69c01ffeR9

The context is that I am building a brand new plugin template, and I started by:

  1. Using GitHub's official "TypeScript Action Starter Template"
  2. Pulling in our ts-template
  3. Finally pulling in our plugin-template

Is this required?

TLDR: This PR should be closed.

I don't think permissions: write-all is required.

Check knip-reporter.yml from the https://github.com/ubiquity/pay.ubq.fi repository which works fine without permissions: write-all.

Update: Yes, permissions: write-all is not required. By default knip-reporter.yml runs in a privileged context because of on: workflow_run. Here github token of the github-actions app is passed which by default has read/write permission for all of the scopes.

Screenshot 2024-10-01 at 10 18 55

@0x4007 0x4007 closed this Oct 1, 2024
@rndquu rndquu deleted the 0x4007-patch-2 branch October 1, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants