chore: make EXCLUDED_FILES optional and refactor

ubiquity · Dec 13, 2024 · 573872f · 573872f
1 parent 78c59b5
commit 573872f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 14 deletions.
diff --git a/.github/empty-string-checker.ts b/.github/empty-string-checker.ts
@@ -6,24 +6,17 @@ const token = process.env.GITHUB_TOKEN;
 const [owner, repo] = process.env.GITHUB_REPOSITORY?.split("/") || [];
 const pullNumber = process.env.GITHUB_PR_NUMBER || process.env.PULL_REQUEST_NUMBER || "0";
 const baseRef = process.env.GITHUB_BASE_REF;
-const excludeEnv = process.env.EXCLUDED_FILES;
-const excludedFiles: string[] = [];
+const excludedFiles: string[] = process.env.EXCLUDED_FILES
+  ? process.env.EXCLUDED_FILES.split("\n")
+      .map((file) => file.trim())
+      .filter(Boolean)
+  : [];
 
-if (!token || !owner || !repo || pullNumber === "0" || !baseRef || excludeEnv === undefined) {
+if (!token || !owner || !repo || pullNumber === "0" || !baseRef) {
   core.setFailed("Missing required environment variables.");
   process.exit(1);
 }
 
-// Only process excludeEnv if it has content
-if (excludeEnv.length > 0) {
-  excludedFiles.push(
-    ...excludeEnv
-      .split("\n")
-      .map((file) => file.trim())
-      .filter(Boolean)
-  );
-}
-
 const octokit = new Octokit({ auth: token });
 const git = simpleGit();
 

diff --git a/.github/workflows/no-empty-strings.yml b/.github/workflows/no-empty-strings.yml
@@ -34,4 +34,3 @@ jobs:
           GITHUB_REPOSITORY: ${{ github.repository }}
           GITHUB_PR_NUMBER: ${{ github.event.pull_request.number }}
           GITHUB_BASE_REF: ${{ github.base_ref }}
-          EXCLUDED_FILES: