Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: read cloudflare credentials from action input #3

Merged
merged 1 commit into from
Mar 13, 2024
Merged

ci: read cloudflare credentials from action input #3

merged 1 commit into from
Mar 13, 2024

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Mar 12, 2024

Resolves #1

We can't read organization secrets from composite actions (related stackoverflow question).

This PR updates cloudflare deploy action to receive cloudflare account id and API token from action inputs.

So the flow is this one:

  1. On a new PR init is called
  2. After init the build is called (which has access to organization secrets)
  3. Build calls cloudflare deploy action and passes cloudflare credentials

@rndquu rndquu requested a review from 0x4007 March 12, 2024 10:26
@0x4007
Copy link
Member

0x4007 commented Mar 13, 2024

Can you also update ts-template with any necessary changes, presumably init.yml?

@rndquu
Copy link
Member Author

rndquu commented Mar 13, 2024

Can you also update ts-template with any necessary changes, presumably init.yml?

Sure, as soon as this one is merged

0x4007
0x4007 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I expected a lot more changes. As long as it works then we're good to go.

@0x4007 0x4007 merged commit 5f7a489 into main Mar 13, 2024
2 checks passed
@rndquu rndquu deleted the ci/read-cf-creds-from-input branch March 13, 2024 14:21
@ubiquibot ubiquibot bot mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4007 0x4007 0x4007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Secure Secrets for Generalized Continuous Deploys
2 participants
@rndquu @0x4007