Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configuration files do not load asynchronously #236

Merged

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen commented Jan 18, 2025

Resolves #227

  • added more logs for better debugging
  • configuration files load synchronously
  • octokit logs are now logged through the official octokit plugin
  • added watson logs to control the level of the logs
  • explicitly bound fetch function within octokit

The configuration files seemed to be the bottleneck, and the kernel seems more stable. Now, it can be a pure coincidence and I became superstitious. The best way to find out is to deploy it and monitor it.

gentlementlegen and others added 30 commits October 11, 2024 16:17
…ranches--main--components--ubiquity-os-kernel

chore(main): release 2.2.0
…ranches--main--components--ubiquity-os-kernel

chore(main): release 2.3.0
…ranches--main--components--ubiquity-os-kernel

chore(main): release 2.4.0
…ranches--main--components--ubiquity-os-kernel

chore(main): release 2.5.0
…ranches--main--components--ubiquity-os-kernel

chore(main): release 2.5.1
fix: update public key to match new private key
…ranches--main--components--ubiquity-os-kernel

chore(main): release 2.5.2
…ranches--main--components--ubiquity-os-kernel

chore(main): release 2.5.3
…ranches--main

chore(main): release 2.5.4
…ranches--main

chore(main): release 2.5.5
@gentlementlegen gentlementlegen marked this pull request as ready for review January 18, 2025 07:58
Copy link
Member

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this works

@@ -1,6 +1,6 @@
name = "ubiquity-os-kernel"
main = "src/adapters/cloudflare-worker.ts"
compatibility_date = "2023-12-06"
compatibility_date = "2024-09-23"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you try this before changing to sync config fetch? it could be also that there was a bug in workers and we were using an old version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I did, didn't notice any change of behavior afterwards

@gentlementlegen gentlementlegen merged commit cf248d1 into ubiquity-os:development Jan 19, 2025
3 checks passed
@gentlementlegen gentlementlegen deleted the fix/async-file-load branch January 19, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kernel gets stuck and does not compute any comment if too many simultaneous requests are sent
3 participants