Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Supabase configuration and initial database setup #178

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen commented Oct 28, 2024

Resolves #32

Moved the Supabase migrations from https://github.com/ubiquity/ubiquibot here because we are still using the DB and this is needed to do a local setup, or eventually to move the db to another instance. This is specially relevant because now Supabase limits to 2 active instances which makes local setup required for ease of use.

Introduces Supabase configuration specifying project settings and an initial database migration
@gentlementlegen gentlementlegen marked this pull request as ready for review October 28, 2024 06:37
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gentlementlegen Right now if one of our core plugins needs to update a DB schema (example) then its migration is saved directly in the plugin's repository. Shouldn't we move all plugins' individual migrations to the kernel or at least to some dedicated repository?

@gentlementlegen
Copy link
Member Author

gentlementlegen commented Oct 28, 2024

@rndquu Ideally all the plugins should use their own DB except for anything related to OAuth login since this one should be shared by everything. We can have a dedicated repository for this, otherwise that migration should indeed be moved here.

Having a separate repo seems cleaner because the Kernel does not reference supabase and doesn't need it to run, and that would avoid polluting the repo. I will create a repo.

@rndquu
Copy link
Member

rndquu commented Oct 28, 2024

Ideally all the plugins should use their own DB

I've thought that we decided that all core plugins use a shared DB

@gentlementlegen
Copy link
Member Author

@rndquu I feel like we had these discussions over and over again so at this point I am not even sure. Either way it will be simple for new devs / external orgs to have that repo on the side since it won't be required to set up the project, except for self host and local setup. Created https://github.com/ubiquity-os/database will push in a minute and close this PR.

@gentlementlegen
Copy link
Member Author

Closed via the creation of a separate repository: https://github.com/ubiquity-os/database

@gentlementlegen gentlementlegen deleted the chore/supabase branch October 28, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration system for Supabase database
2 participants