Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error messages #29

Merged
merged 38 commits into from
Dec 12, 2024
Merged

fix: error messages #29

merged 38 commits into from
Dec 12, 2024

Conversation

gentlementlegen
Copy link
Member

Resolves #28

0x4007
0x4007 reviewed Dec 8, 2024
View reviewed changes
src/handlers/query-wallet.ts Outdated Show resolved Hide resolved
src/handlers/command-parser.ts Outdated Show resolved Hide resolved
gentlementlegen and others added 12 commits December 8, 2024 20:09
@gentlementlegen
Copy link
Member Author

@0x4007 QA: Meniole#8

@gentlementlegen gentlementlegen marked this pull request as ready for review December 8, 2024 14:05
whilefoo
whilefoo reviewed Dec 9, 2024
View reviewed changes
src/plugin.ts Outdated Show resolved Hide resolved
tests/__mocks__/handlers.ts Outdated Show resolved Hide resolved
src/plugin.ts Outdated Show resolved Hide resolved
src/adapters/supabase/helpers/wallet.ts Outdated Show resolved Hide resolved
src/adapters/supabase/helpers/wallet.ts Show resolved Hide resolved
manifest.json Show resolved Hide resolved
@gentlementlegen gentlementlegen mentioned this pull request Dec 10, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

Unused files (1)

src/utils.ts

@gentlementlegen
Copy link
Member Author

New QA: Meniole#8 (comment)

@0x4007
Copy link
Member

0x4007 commented Dec 11, 2024

New QA: Meniole#8 (comment)

I left some feedback there Meniole#8 (comment)

0x4007
0x4007 reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@0x4007 0x4007 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine just need to include my QA comment adjustments. Basically adjust the posted comments.

@gentlementlegen
Copy link
Member Author

@0x4007 Updated the outputs according to your suggestion: Meniole#8 (comment)

@gentlementlegen gentlementlegen merged commit bfd38c3 into ubiquity-os-marketplace:development Dec 12, 2024
2 checks passed
@gentlementlegen gentlementlegen deleted the fix/error-messages branch December 12, 2024 06:10
@ubiquity-os-beta ubiquity-os-beta bot mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4007 0x4007 0x4007 left review comments

@whilefoo whilefoo whilefoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

December 2024 Fixes
3 participants
@gentlementlegen @0x4007 @whilefoo